New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong method name #16

Closed
sokolandrei opened this Issue May 26, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@sokolandrei
Copy link

sokolandrei commented May 26, 2018

UnityEvent.RewardedVideoReceived.Emit(adUnitId, reward.getLabel(),

Should be RewardedVideoReceivedReward, not RewardedVideoReceived to receive event in Unity:

public void EmitRewardedVideoReceivedRewardEvent(string argsJson)

@aornelas

This comment has been minimized.

Copy link
Contributor

aornelas commented May 29, 2018

Thanks for your report! We'll include this fix on the next release.

Cheers!

@mertkurum

This comment has been minimized.

Copy link

mertkurum commented May 29, 2018

There is also one more naming issue on IsConsentDialogLoaded. It is used as IsConsentDialogReady on Android.

@HugoLec

This comment has been minimized.

Copy link

HugoLec commented May 31, 2018

A little hot fix in waiting of next release :

Add this method in the MoPubManager.cs (unity Side, class imported by the unitypackage)

    public void EmitRewardedVideoReceivedEvent(string argsJson)
    {
        EmitRewardedVideoReceivedRewardEvent(argsJson)
    }

It simply forwards the call to the EmitRewardedVideoReceivedRewardEvent method, but it has the correct signature. The two platforms Android and iOS should now be supported.

Thanks for the issue

@aornelas

This comment has been minimized.

Copy link
Contributor

aornelas commented Jun 7, 2018

This has been fixed in the 5.1.0 release.

Thanks again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment