New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Second Factor Authentication to Moqui #484
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to get started with the totp service
…lay the qr code or something
…de it impossible to login
…ction for server rendered screens
…e UserAccountDetail.xml and Account.xml screens and subscreens
…ftl; finished first working pass of UserGroups requiring authc factor; change single use codes to 6 or 8 digits
…lookup, can be an issue if a UserAccount is created and logged in with Shiro saving in session, but then the transaction rolls back and there is another attempt with the same username
…the buttons "Add Single Use Code" and "Add Email Factor"
… there is no WebFacade
…ime to avoid very slow random number generate, don't send code automatically when creating an email authc factor, use button in UI to trigger explicitly for less surprise; some small formatting changes
…roRealm.getAuthenticationInfo() and remove the service
…h the totp service
…de it impossible to login
…e UserAccountDetail.xml and Account.xml screens and subscreens
…ftl; finished first working pass of UserGroups requiring authc factor; change single use codes to 6 or 8 digits
…h the totp service
Because of a lack of planning on my part with git commits on several occasions, I have created a separate, identical pull request: #485. Closing this PR due to redundant code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request makes changes to moqui-framework, moqui-runtime, and SimpleScreens.
The biggest things to check are:
In moqui-framework:
dev.samstevens.totp:totp:1.7.1