Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Second Factor Authentication to Moqui #484

Closed
wants to merge 138 commits into from

Conversation

acetousk
Copy link
Member

The pull request makes changes to moqui-framework, moqui-runtime, and SimpleScreens.

The biggest things to check are:

  • In my development environment, I was occasionally getting 28 second loading screens when calling services in UserServices.xml to create a UserAuthcFactor. Make sure that in other environments this doesn't happen.
  • Ensure that the forms don't allow the user to specify their userId so that permissions for users are enforced.

In moqui-framework:

  • a dependency is added to a build.gradle file: dev.samstevens.totp:totp:1.7.1
  • Email templates, configuration, and files are added for:
    • Sending single use codes
    • Adding the email authc type
    • Notifying the main email address about a new email authc type
  • The UserAuthcFactor entity in UserServices.xml
  • A minor change to UserGroup entity where the UserGroup can require the users to have a UserAuthcFactor
  • Changes to the login process required for having a secondary authentication
  • Other necessary minor misc changes to the code

diviun and others added 30 commits February 8, 2021 23:37
Signed-off-by: acetousk <diviunooda@gmail.com>
Signed-off-by: acetousk <acetousk@gmail.com>
…e UserAccountDetail.xml and Account.xml screens and subscreens
…ftl; finished first working pass of UserGroups requiring authc factor; change single use codes to 6 or 8 digits
jonesde and others added 28 commits June 30, 2021 23:12
…lookup, can be an issue if a UserAccount is created and logged in with Shiro saving in session, but then the transaction rolls back and there is another attempt with the same username
…the buttons "Add Single Use Code" and "Add Email Factor"
…ime to avoid very slow random number generate, don't send code automatically when creating an email authc factor, use button in UI to trigger explicitly for less surprise; some small formatting changes
…roRealm.getAuthenticationInfo() and remove the service
…e UserAccountDetail.xml and Account.xml screens and subscreens
…ftl; finished first working pass of UserGroups requiring authc factor; change single use codes to 6 or 8 digits
@acetousk
Copy link
Member Author

acetousk commented Jul 2, 2021

Because of a lack of planning on my part with git commits on several occasions, I have created a separate, identical pull request: #485.

Closing this PR due to redundant code changes.

@acetousk acetousk closed this Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants