New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a better error message if the accessibility check fails because there is no UI window #257

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@moredip

This comment has been minimized.

Show comment
Hide comment
@moredip

moredip Nov 24, 2013

Owner

Great idea. Thanks for helping future folks getting started!

Owner

moredip commented Nov 24, 2013

Great idea. Thanks for helping future folks getting started!

@moredip

This comment has been minimized.

Show comment
Hide comment
@moredip

moredip Nov 24, 2013

Owner

@FluffyJack actually I just realized this doesn't pass CI. Specifically, it looks like the OS X version doesn't compile now.
https://travis-ci.org/moredip/Frank/builds/14402070

To reproduce this locally you probably just need to compile the OS X target Frank target in XCode. Alternatively, just run rake from the root of the Frank project.

Owner

moredip commented Nov 24, 2013

@FluffyJack actually I just realized this doesn't pass CI. Specifically, it looks like the OS X version doesn't compile now.
https://travis-ci.org/moredip/Frank/builds/14402070

To reproduce this locally you probably just need to compile the OS X target Frank target in XCode. Alternatively, just run rake from the root of the Frank project.

@moredip

This comment has been minimized.

Show comment
Hide comment
@moredip

moredip Nov 24, 2013

Owner

Oh and for bonus points if you could convert the [NSDictionary dictionaryWithObjects:] and [NSArray arrayWithObjects:] usage to @{} and @[] while you're in that file I'd be very grateful.

Owner

moredip commented Nov 24, 2013

Oh and for bonus points if you could convert the [NSDictionary dictionaryWithObjects:] and [NSArray arrayWithObjects:] usage to @{} and @[] while you're in that file I'd be very grateful.

@FluffyJack

This comment has been minimized.

Show comment
Hide comment
@FluffyJack

FluffyJack Nov 24, 2013

Sorry, did it real quick and just submitted it. I'll fix it up soon :)

FluffyJack commented Nov 24, 2013

Sorry, did it real quick and just submitted it. I'll fix it up soon :)

@FluffyJack FluffyJack closed this Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment