Fix SkipUntil to not call MoveNext past end of sequence #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calls to MoveNext after enumerator end.
Contributor
Author
It is not, sorry I copy paste to quickly. I updated the first comment.. It's a re-called MoveNext on sequence end issue. |
Member
So this is the fix for issue #664? |
Contributor
Author
Indeed, I forgot to mention it 😕 |
- empty sequence for input - one-item sequence, predicate succeed - one-item sequence, predicate don't succeed - predicate succeed on first item - predicate succeed on last item - predicate never succeed
atifaziz
requested changes
Nov 12, 2019
Member
atifaziz
left a comment
atifaziz
left a comment
There was a problem hiding this comment.
There are just minor cosmetic & polishing touches needed and then we're good to merge this.
Thanks!
atifaziz
changed the title
* Update SkipUntil.cs: Formatting * Update SkipUntilTest.cs: Test readability
Orace
commented
Nov 12, 2019
Contributor
Author
Orace
left a comment
Orace
left a comment
There was a problem hiding this comment.
It will not compile without this.
Coding may be hard
Contributor
Author
|
A squash merge may reduce my shame |
atifaziz
approved these changes
Nov 12, 2019
Member
atifaziz
left a comment
atifaziz
left a comment
There was a problem hiding this comment.
Thanks for this fix! All looks good! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a part of #649Fork of #660
SkipUntil called MoveNext after sequence end