fix(lib): add opacity 0 (#168) #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
🦋 Changeset detectedLatest commit: 97ae152 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Slide and Zoom flicker when the element is just entering the view and certain conditions are met. Slide flickers when direction is up. Zoom flickers when it is styled. This bug is shown in this Code Sandbox, https://codesandbox.io/s/react-awesome-reveal-bug-vy35p2 . This is fixed by applying opacity: 0 when the element is not in view. resolve #168
|
Hi @Bro3Simon, thank you for this PR 🙌 Setting I'm approving it, great job! |
|
@morellodev, glad to have helped. I learned a few things along the way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlideandZoomflicker when the element is just entering the view and certain conditions are met.Slideflickers fordirection="up".Zoomflickers when it is styled. This bug is shown in this Code Sandbox, https://codesandbox.io/s/react-awesome-reveal-bug-vy35p2 .There might be a bigger issue that is shown when inspecting in the browser. The class for these elements is flickering back and forth when the element is just entering the view. It seems it doesn't know what class to apply. It should apply one class or the other not flipping back and forth between the two. Since I don't know how to fix that, this branch fixes the visible bug by applying
opacity: 0when the element is not in view.resolve #168