Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional config formats #164

Closed
jayvdb opened this issue Jan 16, 2019 · 4 comments
Closed

Additional config formats #164

jayvdb opened this issue Jan 16, 2019 · 4 comments
Assignees
Projects
Milestone

Comments

@jayvdb
Copy link
Member

jayvdb commented Jan 16, 2019

Currently moban only supports yaml as the config format.

anytemplate uses anyconfig to support:

  • JSON
  • ini
  • pickle
  • xml
  • Java properties
  • B-sh
  • yaml
  • toml
  • configobj

It would probably make sense to define a plugin layer for input data formats, keep the existing yaml as a native plugin, and add a 'anyconfig' plugin which provides supports for all the other formats.

I can see a lot of potential for growth by adding specific file formats, like .spec , and more complex data structures like SPDX license metadata files (so that templates do not need to load large data files).

@chfw
Copy link
Member

chfw commented Jan 16, 2019

Cannot agree more!

@chfw chfw added this to in-progress in 0.7.x Jan 18, 2019
@jayvdb jayvdb added this to Backlog in parity Jan 19, 2019
@chfw chfw self-assigned this Jan 20, 2019
chfw added a commit that referenced this issue Jan 22, 2019
…oaded and used by moban. what's more, 'overrides' syntax is promoted to accept any data format, child.yml could override parent.json. related to #164
@chfw
Copy link
Member

chfw commented Jan 22, 2019

With the new implementation, a new feature emerges: any data file can override any data file. for example:

child.yaml:

overrides: parent.json
...

or

child.json:

overrides: parent.yaml
....

@chfw
Copy link
Member

chfw commented Jan 22, 2019

and new data loader can be added in the same way as jinja2 plugins.

@jayvdb jayvdb added this to the 0.4.0 milestone Jan 24, 2019
@jayvdb jayvdb pinned this issue Jan 24, 2019
@jayvdb jayvdb unpinned this issue Jan 24, 2019
@chfw chfw mentioned this issue Jan 24, 2019
@chfw
Copy link
Member

chfw commented Jan 25, 2019

all other data config could be written as a built-in module if no external dependencies or as a moban plugin. Hence, case closed.

@chfw chfw closed this as completed Jan 25, 2019
@chfw chfw moved this from in-progress to done in 0.7.x Jan 25, 2019
@chfw chfw moved this from done to released in 0.7.x Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
parity
Ready
Development

No branches or pull requests

2 participants