Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Nov 4, 2018

+requires:
+  - https://gitlab.com/coala/mobans.git
 configuration:
   template_dir:
     - .moban.dt/
-    - ../coala-mobans/templates/
-    - ../coala-mobans/assets/
+    - mobans:templates/
+    - mobans:assets/
   configuration: .moban.yaml
-  configuration_dir: ../coala-mobans/
+  configuration_dir: "mobans:" <--- get this supported --<<

@chfw chfw requested review from PrajwalM2212 and jayvdb November 4, 2018 21:50
@codecov-io
Copy link

codecov-io commented Nov 4, 2018

Codecov Report

Merging #112 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   98.42%   98.43%   +<.01%     
==========================================
  Files          34       34              
  Lines        1653     1658       +5     
==========================================
+ Hits         1627     1632       +5     
  Misses         26       26
Impacted Files Coverage Δ
moban/_version.py 100% <100%> (ø) ⬆️
tests/test_docs.py 100% <100%> (ø) ⬆️
moban/engine.py 97.67% <88.23%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d357b7...c0a228f. Read the comment docs.

@chfw chfw merged commit da3d1eb into master Nov 5, 2018
@chfw chfw deleted the config-as-requires branch November 17, 2018 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants