Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix moban.exceptions.NoThirdPartyEngine: jinja2 #123

Merged
merged 1 commit into from Nov 14, 2018

Conversation

PrajwalM2212
Copy link
Collaborator

@PrajwalM2212 PrajwalM2212 commented Nov 13, 2018

Closes #121

Before raising the PR, here is a check list:

  1. have you written unit tests for your code changes?
  2. have you run "make format"?
  3. are you requesting to "dev"?
  4. have you updated the change log?
  5. do you think that you can understand your changes after 6 month?
    5.1) can someone else understand your changes without your explanation?
  6. are you pround of your code changes?
    6.1) do you have the feeling of achievement?

@PrajwalM2212
Copy link
Collaborator Author

Travis is failing due to

  1. Formatting errors.
  2. unicode was originally used for handlebars which is incompatible with python3

I will fix those when I am free.

@chfw chfw changed the base branch from master to dev November 13, 2018 18:22
moban/engine_factory.py Outdated Show resolved Hide resolved
moban/engine_handlebars.py Show resolved Hide resolved
moban/engine.py Outdated Show resolved Hide resolved
moban/engine.py Outdated Show resolved Hide resolved
moban/engine.py Outdated Show resolved Hide resolved
moban/engine_handlebars.py Outdated Show resolved Hide resolved
moban/engine_handlebars.py Outdated Show resolved Hide resolved
@PrajwalM2212
Copy link
Collaborator Author

screen shot 2018-11-14 at 6 32 44 am

Working as usual

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #123 into dev will increase coverage by 0.01%.
The diff coverage is 98.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #123      +/-   ##
==========================================
+ Coverage   98.55%   98.57%   +0.01%     
==========================================
  Files          37       37              
  Lines        1874     1891      +17     
==========================================
+ Hits         1847     1864      +17     
  Misses         27       27
Impacted Files Coverage Δ
moban/base_engine.py 100% <ø> (ø) ⬆️
moban/engine_factory.py 93.42% <ø> (+0.01%) ⬆️
moban/mobanfile.py 100% <100%> (ø) ⬆️
moban/engine_handlebars.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (ø) ⬆️
tests/test_engine.py 100% <100%> (ø) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
moban/engine.py 98.97% <97.14%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae00754...471645a. Read the comment docs.

Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will get these changes and I will improve a bit later.

@chfw chfw merged commit 6b55072 into moremoban:dev Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants