New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix moban.exceptions.NoThirdPartyEngine: jinja2 #123
Conversation
Travis is failing due to
I will fix those when I am free. |
f7364f8
to
dc3ad6f
Compare
dc3ad6f
to
471645a
Compare
Codecov Report
@@ Coverage Diff @@
## dev #123 +/- ##
==========================================
+ Coverage 98.55% 98.57% +0.01%
==========================================
Files 37 37
Lines 1874 1891 +17
==========================================
+ Hits 1847 1864 +17
Misses 27 27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will get these changes and I will improve a bit later.
Closes #121
Before raising the PR, here is a check list:
5.1) can someone else understand your changes without your explanation?
6.1) do you have the feeling of achievement?