Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented May 24, 2020

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

chfw added 3 commits May 23, 2020 13:38
* ✨enabled plugins dir via command line

* 📚 update exit code

* 🔬 test -pd on command line

* 📚 update readme

* 🐛 fix unit test which failed to detect the missing feature

* 🔨 code refactor copy engine and strip content processor

* 📚 here is the way to write modelines remover. #36

* 🔨 code refactoring
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #386 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   96.04%   96.10%   +0.06%     
==========================================
  Files          56       59       +3     
  Lines        2907     2952      +45     
==========================================
+ Hits         2792     2837      +45     
  Misses        115      115              
Impacted Files Coverage Δ
moban/_version.py 100.00% <100.00%> (ø)
moban/constants.py 100.00% <100.00%> (ø)
moban/core/content_processor.py 100.00% <100.00%> (ø)
moban/core/mobanfile/__init__.py 98.57% <100.00%> (-0.27%) ⬇️
moban/core/utils.py 100.00% <100.00%> (ø)
moban/main.py 100.00% <100.00%> (ø)
moban/plugins/copy.py 100.00% <100.00%> (ø)
moban/plugins/strip.py 100.00% <100.00%> (ø)
tests/test_copy_engine.py 100.00% <100.00%> (ø)
tests/test_docs.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dcce09...c624522. Read the comment docs.

@chfw chfw merged commit 6327c62 into master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants