New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using more than one variable in the path, the retried request fails #3

Closed
href opened this Issue Aug 17, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@href
Member

href commented Aug 17, 2015

If a path like /page/{type}/{id} is retried using more.transaction, the request is no longer correctly parsed and the wrong view is found. /page/{type} works fine.

The fix seems rather simple. We need to reset the request correctly when attempting a new request:

if attempts != 1:
    request.make_body_seekable()
    request.unconsumed = parse_path(request.path_info)

(note the request.unconsumed line)

I'll write a test and a bugfix.

@href href closed this in 85d208f Aug 17, 2015

@href

This comment has been minimized.

Show comment
Hide comment
@href

href Aug 17, 2015

Member

@faassen May I get a release with this fix or can you give me the right to do one on my own? Assuming you're okay with how I fixed this.

Member

href commented Aug 17, 2015

@faassen May I get a release with this fix or can you give me the right to do one on my own? Assuming you're okay with how I fixed this.

@faassen

This comment has been minimized.

Show comment
Hide comment
@faassen

faassen Aug 17, 2015

Member

I just added you so you can do the release! Thanks for the fix!

Member

faassen commented Aug 17, 2015

I just added you so you can do the release! Thanks for the fix!

@href

This comment has been minimized.

Show comment
Hide comment
@href

href Aug 17, 2015

Member

Awesome! Thank you.

Member

href commented Aug 17, 2015

Awesome! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment