New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move and document pdb API #328

Closed
faassen opened this Issue May 13, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@faassen
Copy link
Member

faassen commented May 13, 2015

There's an API 'morepath.pdb', which you can use instead of 'pdb' to start the debugger so it skips Reg and a few other things. It's handy for debugging Morepath.

I just got a report that 'morepath.pdb' by importing from 'pdb' also imports 'readline' which in some circumstances can trigger an issue with code that tries to override readline such as pyreadline. While I think this ought not to happen in the first place and importing 'readline' should be safe, it did happen in practice and that weighs more strongly.

A way to make this error less likely to occur would be to move it away from __init__.py into its own module, 'pdb'. It shouldn't be called 'pdb' though as this would make an 'import pdb' trigger a relative import giving much confusion. So perhaps 'morepath.pdbsupport'. It's a more cumbersome import but it's less likely to trip up code.

While we're at it we should also document it in the public docs.

@faassen faassen added this to the 0.11 milestone May 13, 2015

@faassen faassen closed this in c173320 Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment