Tab to select #164
Closed
Tab to select #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/AutosuggestContainer.js
rickhanlonii
force-pushed
the
tab-as-select
branch
from
4c9cea5
to
67ac04f
Compare
|
|
||
| case 'Tab': { | ||
| if (tabToSelect) { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
This may need to be moved inside the if below. Users may want to tab to another field when there's no focused suggestion.
|
@rickhanlonii Thanks a lot for a detailed PR! I must admit that I'm a bit confused with the functionality you are trying to achieve. In #163 you mentioned "Slack user mentions". As far as I can see, pressing Tab in Slack is somewhat equivalent to pressing Down, not pressing Enter, i.e. it moves to the next suggestion rather than selecting the focused one. The URL bar in Chrome behaves the same. Am I missing something? |
|
Great point @moroshko, I'll update and re-open. |
| @@ -54,6 +54,18 @@ export const onSuggestionsUpdateRequested = sinon.spy(({ value }) => { | |||
| }); | |||
| }); | |||
|
|
|||
| export const tabToSelect = { | |||
There was a problem hiding this comment.
Note: also going to update this API per the comments here.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a setting
tabToSelectto allow tabbing to select suggestion.Closes #163
Details
tabToSelect(defaults to false)Tabevent type toonSuggestionsUpdateRequestedandonSuggestionSelected