Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make sure it also works in scrolling parents #4

Merged
merged 1 commit into from Feb 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

fhackenberger commented Jan 31, 2013

Until this patch the appear plugin did not fire any events in the following scenario:

<body>
<div>
  ....
  <div style="overflow-y: scroll">
    .....
    <div class="appear-marker"></div>
  </div>
  ....
</div>
</body>
Make sure it also works in scrolling parents
Until this patch the appear plugin did not fire any events in the following scenario:

<body>
<div>
  ....
  <div style="overflow-y: scroll">
    .....
    <div class="appear-marker"></div>
  </div>
  ....
</div>
</body>

morr added a commit that referenced this pull request Feb 2, 2013

Merge pull request #4 from fhackenberger/patch-1
Make sure it also works in scrolling parents

@morr morr merged commit 075573a into morr:master Feb 2, 2013

Owner

morr commented on jquery.appear.js in 0940aef Feb 6, 2013

@fhackenberger hi!
I reverted this changes. Unfortunately they are not working as expected. Please check this demo page http://morr.github.com/appear.scroll.html and try to scroll overflowed div.
Overflowed elements became "appeared" even when they are not visible. It is not enough just to add additional event handler for overflow=scroll containers, you have to consider this situation in "process" function. Unfortunately it is not very efficient and it is rather complicated check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment