Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomenclature (for Pie/Donut charts) #143

Closed
tiraeth opened this issue Dec 27, 2012 · 0 comments
Closed

Nomenclature (for Pie/Donut charts) #143

tiraeth opened this issue Dec 27, 2012 · 0 comments

Comments

@tiraeth
Copy link
Contributor

tiraeth commented Dec 27, 2012

I am coming with a proposal of fixing nomenclature (for Pie and Donut charts). Right now, in internal functions, Morris.js is using segment while it should use sector.

In geometry the "pizza" slice is called "sector" while "segment" is just a slice made by chord.

I think this Issue is a good start point for checking and fixing all namings in Morris.js (for example, when this is solved we can provide an option called minSectorAngle which is related to #92).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants