Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements and added OsName to Launcher #671

Merged
merged 4 commits into from Aug 8, 2019

Conversation

@furesoft
Copy link
Contributor

commented Aug 7, 2019

  • improved string.split method
  • added OsName to Launcher UI and Options
  • added furesoft to Contributor List
@tgiphil

tgiphil approved these changes Aug 7, 2019

startPos = i + 1;
}
}
if (temp != "")

This comment has been minimized.

Copy link
@tgiphil

tgiphil Aug 7, 2019

Member

Change “” to string.Empty

This comment has been minimized.

Copy link
@furesoft

furesoft Aug 7, 2019

Author Contributor

i did, you can merge the PR

@furesoft

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

i have fixed the string initialisation and check

@tgiphil tgiphil merged commit 4b9d608 into mosa:master Aug 8, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.