Deepspeed Integration #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbloxham
force-pushed
the
deepspeed-integration
branch
from
35bbee2
to
7556fcd
Compare
jbloxham
requested review from
Averylamp,
ravi-mosaicml,
abhi-mosaic,
ajaysaini725 and
siriuslee
Averylamp
approved these changes
Dec 1, 2021
jbloxham
force-pushed
the
deepspeed-integration
branch
from
ead595e
to
5c14354
Compare
| @pytest.mark.gpu | ||
| @pytest.mark.parametrize("world_size", [pytest.param(1), pytest.param(2, marks=pytest.mark.world_size(2))]) | ||
| def test_deepspeed(world_size: int, mosaic_trainer_hparams: TrainerHparams, tmpdir: pathlib.Path) -> None: | ||
| """Pretty much just copied from ./test_ddp""" |
There was a problem hiding this comment.
#110 changes the DDP test fyi
Closed
coryMosaicML
pushed a commit
to coryMosaicML/composer
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for using DeepSpeed instead of Pytorch DDP in the trainer. Somewhat WIP, but good enough to merge for now. The major TODOs are:
I'm waiting on a node to run a quick regression test.