Isolating JSON parsing exception in jsonParse #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous code, the entire callback along with JSON parsing was encapsulated with a try / catch block. Thus any error that occurs within the callback bubbles up to and is caught in this scope. I added a unit test to specifically test for this in `test\unit\utils\jsonParseTest.js` called `should call the callback only once if an error is thrown in callback execution`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous code, the entire callback along with JSON parsing was
encapsulated with a try / catch block. Thus any error that occurs
within the callback bubbles up to and is caught in this scope.
I added a unit test to specifically test for this in
test\unit\utils\jsonParseTest.jscalledshould call the callback only once if an error is thrown in callback execution.