RCF-1283 - Added config properties for hardcoded values

[MadhuMosip]

Summary by CodeRabbit

• New Features
  • Added endpoint to fetch operator onboarding bioattributes and six guide/help URL endpoints; values exposed via global state.
• UX Improvements
  • Onboarding screens now open help URLs only when present, simplifying flows and avoiding empty links.
• Chores
  • Introduced dynamic server-profile support and updated tests/wiring to include the new global-parameter dependency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds Pigeon APIs and platform bindings to fetch operator onboarding bioattributes and six cached URL getters; wires GlobalParamRepository into DI and services; exposes new getters in repository, master-data service, Dart provider, and updates UI to read/open those URLs.

Changes

Cohort / File(s)	Summary
Constants android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java	Added constants: OPERATOR_ONBOARDING_BIO_ATTRIBUTES, SERVER_ACTIVE_PROFILE, ONBOARD_YOURSELF_URL, REGISTERING_INDIVIDUAL_URL, SYNC_DATA_URL, MAPPING_DEVICES_URL, UPLOADING_DATA_URL, UPDATING_BIOMETRICS_URL.
GlobalParam repository android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java	Added getters for operator bioattributes and six URL keys (e.g., getCachedStringOperatorOnboardingBioAttributes(), getCachedStringOnboardYourselfUrl(), etc.).
MasterData SPI & impl android/clientmanager/src/main/java/io/mosip/registration/clientmanager/spi/MasterDataService.java, .../service/MasterDataServiceImpl.java	Added six interface methods and implementations returning cached URL strings (null-coalesced to empty string).
Android Pigeon handlers android/app/src/main/java/io/mosip/registration_client/api_services/BiometricsDetailsApi.java, android/app/src/main/java/io/mosip/registration_client/api_services/CommonDetailsApi.java	Implemented getOperatorOnboardingBioattributes(...) returning cached string; added six async URL getters in CommonDetailsApi that fetch via MasterDataService and return cached URLs with try/catch logging.
DI & tests android/clientmanager/src/main/java/io/mosip/registration/clientmanager/config/AppModule.java, android/clientmanager/src/test/java/.../AppModuleTest.java	provideUserOnboardService() updated to accept GlobalParamRepository and forward it; tests updated to pass mocked repository.
UserOnboardService & related android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/UserOnboardService.java, .../Biometrics095Service.java	Injected GlobalParamRepository, added getServerActiveProfile() using global param with DEFAULT_SERVER_ACTIVE_PROFILE fallback, replaced prior hard-coded profile usage.
Pigeon interfaces pigeon/biometrics.dart, pigeon/common_details.dart	Added getOperatorOnboardingBioattributes() to BiometricsApi and six URL getters to CommonDetailsApi (async String returns).
Dart SPI & platform impl lib/platform_spi/biometrics_service.dart, lib/platform_android/biometrics_service_impl.dart	Added getOperatorOnboardingBioattributes() to SPI and Android implementation with PlatformException handling.
Flutter provider state lib/provider/global_provider.dart	Added six URL state fields with getters/setters that call notifyListeners() (onboardYourselfUrl, registeringIndividualUrl, syncDataUrl, mappingDevicesUrl, uploadingDataUrl, updatingBiometricsUrl).
UI changes lib/ui/onboard/onboard_landing_page.dart, lib/ui/onboard/widgets/operator_onboarding_biometrics_capture_control.dart	Added _openUrlIfPresent(String url) helper; switched URL opening to use GlobalProvider fields; replaced map-value call with BiometricsApi.getOperatorOnboardingBioattributes() in operator onboarding widget.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant Flutter as Flutter UI
participant Provider as GlobalProvider
participant DartSPI as BiometricsService (SPI)
participant Pigeon as Pigeon channel
participant AndroidAPI as BiometricsDetailsApi / CommonDetailsApi
participant MasterData as MasterDataServiceImpl
participant Repo as GlobalParamRepository

Flutter->>Provider: read URL field or request bioattributes
alt request operator bioattributes
  Flutter->>DartSPI: getOperatorOnboardingBioattributes()
  DartSPI->>Pigeon: invoke getOperatorOnboardingBioattributes()
  Pigeon->>AndroidAPI: call getOperatorOnboardingBioattributes()
  AndroidAPI->>Repo: getCachedStringOperatorOnboardingBioAttributes()
  Repo-->>AndroidAPI: cached string (or null)
  AndroidAPI-->>Pigeon: return String
  Pigeon-->>DartSPI: deliver result
  DartSPI-->>Flutter: return String → Provider updates
else open URL
  Flutter->>Provider: get url
  Provider-->>Flutter: url
  Flutter->>Pigeon: (optional) request URL from CommonDetailsApi or open directly
  Pigeon->>AndroidAPI: getOnboardYourselfUrl()... (if called)
  AndroidAPI->>MasterData: getCachedStringOnboardYourselfUrl()
  MasterData->>Repo: read cached param
  Repo-->>MasterData: string (or null)
  MasterData-->>AndroidAPI: string (or "")
  AndroidAPI-->>Pigeon: return String
  Pigeon-->>Flutter: deliver result
  Flutter->>Browser: open URL if non-empty
end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Verify DI change: AppModule.provideUserOnboardService wiring and tests.
• Confirm Pigeon bindings regenerated and Android/Dart signatures match.
• Check constant keys align between RegistrationConstants, GlobalParamRepository, MasterDataService, and UI usage.
• Review getServerActiveProfile() fallback and any impact on request payloads.

Suggested reviewers

• ase-101
• jayesh12234
• mohanachandran-s

Poem

🐇 I hopped from cache to native call,
fetched bioattributes, and links not small.
Six tiny URLs now sit in a row,
provider listens — off to the browser we go.
Rabbit cheers: small hops, big flow. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.76% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main objective of the PR: replacing hardcoded values with configurable properties accessible through global parameters and provider.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a98475 and 489f1ca.

📒 Files selected for processing (3)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1 hunks)
• android/clientmanager/src/test/java/io/mosip/registration/clientmanager/config/AppModuleTest.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java

🔇 Additional comments (1)

android/clientmanager/src/test/java/io/mosip/registration/clientmanager/config/AppModuleTest.java (1)

262-269: LGTM! Test correctly updated to reflect new dependency.

The addition of globalParamRepository as the final parameter correctly mirrors the updated UserOnboardService constructor signature. The mock is properly declared and initialized.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (6)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/spi/MasterDataService.java (1)

152-164: New cached URL getters are consistent with repository API

The six added getters cleanly extend the SPI and align with GlobalParamRepository naming; no issues spotted. Consider adding brief JavaDoc for each later to document intended semantics (e.g., empty string vs null) if this surface grows further.

lib/platform_android/biometrics_service_impl.dart (1)

183-194: New operator onboarding bioattributes implementation follows existing pattern

The implementation correctly mirrors other methods (default value, PlatformException handling, generic catch, debug logging). Only minor nit: the catch log "Fetch List of Operator Onboarding Bioattributes failed" suggests a list, while the method returns a single String; you may want to rename it to something like "Fetch operator onboarding bioattributes failed" for clarity.

lib/ui/onboard/widgets/operator_onboarding_biometrics_capture_control.dart (1)

35-41: Using dedicated bioattributes API improves clarity

Replacing the hard‑coded key + getMapValue call with getOperatorOnboardingBioattributes() is a good cleanup and better documents intent. If you see flakiness around this fetch later, consider adding basic error handling / fallback (e.g., handling empty or null response) before updating GlobalProvider.

lib/provider/global_provider.dart (1)

228-270: GlobalProvider URL state follows existing ChangeNotifier pattern

The added help/guide URL fields and their getters/setters integrate cleanly with the provider’s state model and notification pattern. If more URLs/config entries accrue, you might later consider grouping them into a dedicated config struct or map to reduce boilerplate, but it’s not necessary right now.

lib/ui/onboard/onboard_landing_page.dart (1)

38-41: Centralized URL opening looks good; consider feedback when URL is unset

Refactoring all help-topic onTap handlers to use _openUrlIfPresent with URLs from GlobalProvider is clean and simplifies the flow.

Right now, an empty URL results in a silent no-op. If misconfiguration is possible, you might optionally log or surface a lightweight message so operators aren’t left with a “dead” tap:

Future<void> _openUrlIfPresent(String url) async {
  if (url.isEmpty) {
    // e.g. debugPrint('Help URL not configured for this topic');
    return;
  }
  await goToUrl(url);
}

Purely a UX/diagnostics improvement; existing behavior is functionally fine.

Also applies to: 52-54, 60-62, 68-69, 75-77, 83-85, 91-93

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/MasterDataServiceImpl.java (1)

1085-1119: Null-safe wrappers for cached URL globals look good

The six new getCachedString*Url methods correctly delegate to GlobalParamRepository and normalize null to "", matching the pattern used elsewhere for global params and avoiding nulls at higher layers.

If this family of getters grows further, you could optionally factor out a small helper to reduce repetition, but it’s not necessary for correctness.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99fba14 and 1c83ab8.

📒 Files selected for processing (17)

• android/app/src/main/java/io/mosip/registration_client/api_services/BiometricsDetailsApi.java (1 hunks)
• android/app/src/main/java/io/mosip/registration_client/api_services/CommonDetailsApi.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/config/AppModule.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/MasterDataServiceImpl.java (1 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/UserOnboardService.java (7 hunks)
• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/spi/MasterDataService.java (1 hunks)
• android/clientmanager/src/test/java/io/mosip/registration/clientmanager/config/AppModuleTest.java (1 hunks)
• android/clientmanager/src/test/java/io/mosip/registration/clientmanager/service/UserOnboardServiceTest.java (9 hunks)
• lib/platform_android/biometrics_service_impl.dart (1 hunks)
• lib/platform_spi/biometrics_service.dart (1 hunks)
• lib/provider/global_provider.dart (1 hunks)
• lib/ui/onboard/onboard_landing_page.dart (2 hunks)
• lib/ui/onboard/widgets/operator_onboarding_biometrics_capture_control.dart (1 hunks)
• pigeon/biometrics.dart (1 hunks)
• pigeon/common_details.dart (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (3)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/UserOnboardService.java (2)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

• GlobalParamRepository (21-214)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-131)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

• RegistrationConstants (9-131)

android/clientmanager/src/test/java/io/mosip/registration/clientmanager/service/UserOnboardServiceTest.java (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

• GlobalParamRepository (21-214)

🔇 Additional comments (10)

pigeon/biometrics.dart (1)

67-68: BiometricsApi extension looks correct

Adding getOperatorOnboardingBioattributes() as an async String method is consistent with the rest of the HostApi and with the platform implementation pattern.

lib/platform_spi/biometrics_service.dart (1)

40-44: SPI surface extended appropriately

The new getOperatorOnboardingBioattributes() method fits the existing BiometricsService contract and matches the Android implementation; no further changes needed here.

android/clientmanager/src/test/java/io/mosip/registration/clientmanager/config/AppModuleTest.java (1)

240-248: Test wiring updated correctly for new constructor dependency

Passing globalParamRepository into provideUserOnboardService matches the updated AppModule signature and ensures the test still validates the binding; no issues here.

android/clientmanager/src/test/java/io/mosip/registration/clientmanager/service/UserOnboardServiceTest.java (1)

27-28: UserOnboardService tests correctly updated for GlobalParamRepository

The added GlobalParamRepository mock, default stubbing of getCachedStringGlobalParam, and the constructor updates across the various test setups keep the tests aligned with the new production constructor and avoid null access on the server profile. This looks consistent and should preserve existing test behavior.

Also applies to: 65-66, 79-86, 86-101, 359-363, 424-430, 460-464, 779-782, 809-812

pigeon/common_details.dart (1)

19-30: Pigeon API extensions for URL getters are consistent

The six new @async URL getters fit the existing CommonDetailsApi pattern and align with the Java implementation; no issues from an interface/contract standpoint.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/config/AppModule.java (1)

273-280: UserOnboardService DI wiring with GlobalParamRepository is correct

The updated provideUserOnboardService adds GlobalParamRepository and passes arguments in the same order as the new constructor, so Dagger wiring remains consistent and supports the new server-profile lookup.

android/app/src/main/java/io/mosip/registration_client/api_services/CommonDetailsApi.java (1)

98-162: URL getter endpoints follow existing global-param pattern

Each of the new get*Url methods wraps the corresponding MasterDataService cached getter with defensive try/catch and an empty-string default, consistent with the rest of this API and safe for the Pigeon bridge. No functional issues here.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/UserOnboardService.java (1)

21-21: Configurable server active profile for IDA requests is a solid improvement

Injecting GlobalParamRepository and routing both IDA request and data-block ENV fields through getServerActiveProfile() removes the hard-coded environment and lets deployments control it via SERVER_ACTIVE_PROFILE, while still defaulting to "Staging" when unset.

The null/blank handling and trim in getServerActiveProfile() look correct and keep behavior stable on older configs.

Also applies to: 85-86, 107-107, 142-155, 160-168, 200-201, 258-259

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/constant/RegistrationConstants.java (1)

120-129: New global-param key constants are consistent and well-named

The added constants for operator onboarding bioattributes, server active profile, and the various help URLs follow the existing mosip.registration.* key convention and align with usages elsewhere in the PR.

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/repository/GlobalParamRepository.java (1)

161-187: New cached getters are consistent and correctly wired to constants

These seven getters cleanly follow the existing pattern of simple globalParamMap.get(...) accessors and are correctly bound to the new RegistrationConstants keys. No functional or API‑shape issues from this change.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/Biometrics095Service.java (1)

318-326: Implementation looks good with proper null-safety.

The method correctly handles null repository and null/empty cached values, falling back to the default profile. The trim operation prevents issues with whitespace in configured values.

Optional enhancement: Consider validating the returned profile value against a known set of valid profiles (e.g., "Developer", "Staging", "Production") to catch configuration errors early:

 private String getServerActiveProfile() {
     if (globalParamRepository != null) {
         String value = globalParamRepository.getCachedStringGlobalParam(RegistrationConstants.SERVER_ACTIVE_PROFILE);
         if (value != null && !value.trim().isEmpty()) {
-            return value.trim();
+            String profile = value.trim();
+            // Optionally validate against known profiles
+            if (profile.matches("^(Developer|Staging|Production)$")) {
+                return profile;
+            }
+            Log.w(TAG, "Unknown server profile configured: " + profile + ", using default");
         }
     }
     return DEFAULT_SERVER_ACTIVE_PROFILE;
 }

This validation is optional and can be deferred if the configuration is tightly controlled or if flexibility for custom profile names is desired.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5511c76 and 4a98475.

📒 Files selected for processing (1)

• android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/Biometrics095Service.java (3 hunks)

🔇 Additional comments (1)

android/clientmanager/src/main/java/io/mosip/registration/clientmanager/service/Biometrics095Service.java (1)

94-94: Good refactoring to use configurable server profile.

Replacing the hardcoded environment value with a configurable parameter improves maintainability and allows environment-specific deployments without code changes.