Docker build fix [MOSIP-44274]#1127
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughMaven download in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
artifacts/pom.xml (3)
221-229: Undefined properties will cause build failure.This artifactItem references
${auth-adapter-java-21.version}and${auth-adapter-java-21.location}, but these properties are not defined in the<properties>section. According to the summary, Java 21 variant properties were removed, but this artifactItem block was not removed.This will cause Maven to either fail the build or use literal unresolved property strings as values.
🐛 Proposed fix: Remove the orphaned artifactItem
- <artifactItem> - <groupId>io.mosip.kernel</groupId> - <artifactId>kernel-auth-adapter</artifactId> - <version>${auth-adapter-java-21.version}</version> - <outputDirectory>${auth-adapter-java-21.location}</outputDirectory> - <!-- Keep the destination filename consistent with the original --> - <destFileName>kernel-auth-adapter.jar</destFileName> - <type>jar</type> - </artifactItem>
261-269: Duplicate artifactItem entry.This
kernel-smsserviceprovider-msg91artifactItem is identical to the one at lines 242-249. This will copy the same artifact twice unnecessarily.🧹 Proposed fix: Remove the duplicate block
-<!-- artifactItem section for smsserviceprovider --> - <artifactItem> - <groupId>io.mosip.kernel</groupId> - <artifactId>kernel-smsserviceprovider-msg91</artifactId> - <version>${kernel-smsserviceprovider.version}</version> - <outputDirectory>${kernel-smsserviceprovider.location}</outputDirectory> - <destFileName>${kernel-smsserviceprovider.fileName}</destFileName> - <type>jar</type> - </artifactItem>
289-297: Undefined properties will cause build failure.This artifactItem references
${kernel-virusscanner-clamav-java-21.version}and${kernel-virusscanner-clamav-java-21.location}, but these properties are not defined. The Java 21 variant properties were removed but this artifactItem was not updated.🐛 Proposed fix: Use the existing non-Java-21 properties
<!-- artifactItem section for virusscanner --> <artifactItem> <groupId>io.mosip.kernel</groupId> <artifactId>kernel-virusscanner-clamav</artifactId> - <version>${kernel-virusscanner-clamav-java-21.version}</version> - <outputDirectory>${kernel-virusscanner-clamav-java-21.location}</outputDirectory> + <version>${kernel-virusscanner-clamav.version}</version> + <outputDirectory>${kernel-virusscanner-clamav.location}</outputDirectory> <destFileName>${kernel-virusscanner-clamav.fileName}</destFileName> <type>jar</type> </artifactItem>
🤖 Fix all issues with AI agents
In `@artifacts/pom.xml`:
- Around line 37-56: Update the ossrh repository configuration: in the
repository with id "ossrh" replace the incorrect <url> value
"https://central.sonatype.com/repositories/snapshots" with the correct Sonatype
snapshots URL "https://central.sonatype.com/repository/maven-snapshots/" by
editing the <url> element inside the ossrh <repository> block in the pom.xml.
Signed-off-by: Gokulraj C <110164849+GOKULRAJ136@users.noreply.github.com> Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: Gokulraj C <110164849+GOKULRAJ136@users.noreply.github.com> Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
GOKULRAJ136
force-pushed
the
patch-16
branch
from
10045f9 to
3689f3c
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
artifacts/Dockerfile (1)
217-217:⚠️ Potential issue | 🔴 CriticalBuild is failing — SNAPSHOT artifact not found.
The pipeline reports that
io.mosip.kernel:kernel-auth-adapter:jar:1.2.1-SNAPSHOTcannot be resolved fromhttps://central.sonatype.com/repositories/snapshots. This is the actual build-breaking error. The Maven version bump alone does not fix this.The root cause is likely in
pom.xml(repository URL or artifact version configuration). Please ensure the correct snapshot repository URL is configured and the referenced artifact version is published there.
🧹 Nitpick comments (2)
artifacts/Dockerfile (2)
39-41: Pipeline warns about legacyENVformat.The linter flags these lines for using the legacy
ENV key valuesyntax instead ofENV key=value. While these aren't part of this change, since this is a Docker build fix PR, it would be a good time to clean them up.Suggested fix
-ENV MAVEN_HOME /usr/local/maven -ENV PATH $MAVEN_HOME/bin:$PATH -ENV JAVA_HOME /usr/lib/jvm/java-11-openjdk-amd64 +ENV MAVEN_HOME=/usr/local/maven +ENV PATH=$MAVEN_HOME/bin:$PATH +ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64
31-32: Upgrade Maven from 3.8.9 (EOL) to 3.9.12 (current stable).Maven 3.8.9 and before has reached end-of-life and is no longer supported. New plugin releases require Maven 3.9.0 or later. Maven 3.9.12 is the latest stable release and is fully compatible with Java 11 (used in this Dockerfile).
Additionally,
dlcdn.apache.orgmay eventually remove EOL versions from the CDN distribution.Suggested upgrade to Maven 3.9.12
-wget https://dlcdn.apache.org/maven/maven-3/3.8.9/binaries/apache-maven-3.8.9-bin.tar.gz &&\ -tar -xzf apache-maven-3.8.9-bin.tar.gz && mv apache-maven-3.8.9 /usr/local/maven && rm apache-maven-3.8.9-bin.tar.gz &&\ +wget https://dlcdn.apache.org/maven/maven-3/3.9.12/binaries/apache-maven-3.9.12-bin.tar.gz &&\ +tar -xzf apache-maven-3.9.12-bin.tar.gz && mv apache-maven-3.9.12 /usr/local/maven && rm apache-maven-3.9.12-bin.tar.gz &&\
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
artifacts/pom.xml (2)
221-229:⚠️ Potential issue | 🔴 CriticalBuild breakage: undefined properties
${auth-adapter-java-21.version}and${auth-adapter-java-21.location}.The Java-21 properties were removed from
<properties>, but thisartifactItemstill references them. Maven will not resolve these, causing the build to fail. This block should be removed along with the other Java-21 artifact items.Proposed fix — remove the orphaned artifactItem
- <artifactItem> - <groupId>io.mosip.kernel</groupId> - <artifactId>kernel-auth-adapter</artifactId> - <version>${auth-adapter-java-21.version}</version> - <outputDirectory>${auth-adapter-java-21.location}</outputDirectory> - <!-- Keep the destination filename consistent with the original --> - <destFileName>kernel-auth-adapter.jar</destFileName> - <type>jar</type> - </artifactItem>
289-297:⚠️ Potential issue | 🔴 CriticalBuild breakage: undefined properties
${kernel-virusscanner-clamav-java-21.version}and${kernel-virusscanner-clamav-java-21.location}.Same issue as the auth-adapter block above. The Java-21 properties were removed, but this
artifactItemstill references them. Update to use the base properties or remove this block.Proposed fix — use the existing non-java-21 properties
<artifactItem> <groupId>io.mosip.kernel</groupId> <artifactId>kernel-virusscanner-clamav</artifactId> - <version>${kernel-virusscanner-clamav-java-21.version}</version> - <outputDirectory>${kernel-virusscanner-clamav-java-21.location}</outputDirectory> + <version>${kernel-virusscanner-clamav.version}</version> + <outputDirectory>${kernel-virusscanner-clamav.location}</outputDirectory> <destFileName>${kernel-virusscanner-clamav.fileName}</destFileName> <type>jar</type> </artifactItem>Alternatively, if this was a Java-21 variant that's no longer needed, remove the entire block.
🧹 Nitpick comments (1)
artifacts/pom.xml (1)
261-269: DuplicateartifactItemforkernel-smsserviceprovider-msg91.This block (lines 261–269) is identical to lines 242–249. Remove one to avoid downloading the same artifact twice.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
artifacts/pom.xml (3)
221-229:⚠️ Potential issue | 🔴 CriticalBuild will fail —
auth-adapter-java-21properties are undefined.This
artifactItemblock references${auth-adapter-java-21.version}and${auth-adapter-java-21.location}, but the corresponding properties were removed in this PR. Maven will leave these as literal unexpanded strings, causing the dependency resolution and file copy to fail.Either remove this entire block (consistent with the stated goal of dropping Java 21 variants) or re-add the properties.
Suggested fix: remove the orphaned artifactItem
- <artifactItem> - <groupId>io.mosip.kernel</groupId> - <artifactId>kernel-auth-adapter</artifactId> - <version>${auth-adapter-java-21.version}</version> - <outputDirectory>${auth-adapter-java-21.location}</outputDirectory> - <!-- Keep the destination filename consistent with the original --> - <destFileName>kernel-auth-adapter.jar</destFileName> - <type>jar</type> - </artifactItem>
289-297:⚠️ Potential issue | 🔴 CriticalBuild will fail —
kernel-virusscanner-clamav-java-21properties are undefined.Same issue as the auth-adapter block above:
${kernel-virusscanner-clamav-java-21.version}and${kernel-virusscanner-clamav-java-21.location}are referenced here but their property definitions were removed. This block should either be removed or updated to use the non-java-21 properties.Suggested fix: use the standard (non-java-21) properties
<artifactItem> <groupId>io.mosip.kernel</groupId> <artifactId>kernel-virusscanner-clamav</artifactId> - <version>${kernel-virusscanner-clamav-java-21.version}</version> - <outputDirectory>${kernel-virusscanner-clamav-java-21.location}</outputDirectory> + <version>${kernel-virusscanner-clamav.version}</version> + <outputDirectory>${kernel-virusscanner-clamav.location}</outputDirectory> <destFileName>${kernel-virusscanner-clamav.fileName}</destFileName> <type>jar</type> </artifactItem>
261-269:⚠️ Potential issue | 🟡 MinorDuplicate
artifactItemforkernel-smsserviceprovider-msg91.This block (lines 262–269) is an exact duplicate of lines 242–249. It will cause Maven to download and copy the same artifact twice. Remove one of them.
Suggested fix
-<!-- artifactItem section for smsserviceprovider --> - <artifactItem> - <groupId>io.mosip.kernel</groupId> - <artifactId>kernel-smsserviceprovider-msg91</artifactId> - <version>${kernel-smsserviceprovider.version}</version> - <outputDirectory>${kernel-smsserviceprovider.location}</outputDirectory> - <destFileName>${kernel-smsserviceprovider.fileName}</destFileName> - <type>jar</type> - </artifactItem>
🧹 Nitpick comments (2)
artifacts/pom.xml (2)
157-167:certify-plugin.locationis defined three times (lines 158, 162, 167).In Maven properties, the last definition wins, so the first two are dead. This is confusing and error-prone. Keep a single definition.
Suggested fix
<!-- certify sunbird plugin --> - <certify-plugin.location>/usr/share/nginx/html/artifactory/libs-release-local/certify/certify-plugin</certify-plugin.location> <!-- <certify-sunbird-plugin.version>0.3.0-SNAPSHOT</certify-sunbird-plugin.version>--> <!-- <certify-sunbird-plugin.fileName>certify-sunbird-plugin.jar</certify-sunbird-plugin.fileName>--> <!-- certify mosip identity plugin --> - <certify-plugin.location>/usr/share/nginx/html/artifactory/libs-release-local/certify/certify-plugin</certify-plugin.location> + <certify-plugin.location>/usr/share/nginx/html/artifactory/libs-release-local/certify/certify-plugin</certify-plugin.location> <certify-mosip-identity-plugin.version>0.3.0-SNAPSHOT</certify-mosip-identity-plugin.version> <certify-mosip-identity-plugin.fileName>certify-mosip-identity-plugin.jar</certify-mosip-identity-plugin.fileName> <!-- certify mock plugin --> - <certify-plugin.location>/usr/share/nginx/html/artifactory/libs-release-local/certify/certify-plugin</certify-plugin.location> <certify-mock-plugin.version>0.3.1-SNAPSHOT</certify-mock-plugin.version>
70-71: Typo in comment: "apadter" → "adapter".- <!-- kernel-auth-apadter --> + <!-- kernel-auth-adapter -->
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
2 participants
Summary by CodeRabbit