From 89df79d653d646b1f9f32582d1d17e56f0d52455 Mon Sep 17 00:00:00 2001 From: Janardhan B S <72377118+JanardhanBS-SyncByte@users.noreply.github.com> Date: Fri, 24 May 2024 18:04:44 +0530 Subject: [PATCH] [MOSIP-33145] (#131) * [MOSIP-33145] Signed-off-by: JanardhanBS-SyncByte * [MOSIP-33145] Signed-off-by: JanardhanBS-SyncByte * [MOSIP-33145] Signed-off-by: JanardhanBS-SyncByte --------- Signed-off-by: JanardhanBS-SyncByte --- .../services/constants/AppConstants.java | 10 +++++++--- .../BioSdkServiceProviderImpl_V_1_0.java | 19 ++++++++++++------- .../biosdk/services/utils/ErrorCode.java | 2 +- 3 files changed, 20 insertions(+), 11 deletions(-) diff --git a/biosdk-services/src/main/java/io/mosip/biosdk/services/constants/AppConstants.java b/biosdk-services/src/main/java/io/mosip/biosdk/services/constants/AppConstants.java index 27c2af54..67b87795 100644 --- a/biosdk-services/src/main/java/io/mosip/biosdk/services/constants/AppConstants.java +++ b/biosdk-services/src/main/java/io/mosip/biosdk/services/constants/AppConstants.java @@ -1,6 +1,10 @@ package io.mosip.biosdk.services.constants; public class AppConstants { - public static final String LOGGER_SESSIONID = "BIO-SDK-PROVIDER"; - public static final String LOGGER_IDTYPE = "REGISTRATION / AUTH"; -} + private AppConstants() { + throw new IllegalStateException("AppConstants class"); + } + + public static final String LOGGER_SESSIONID = "BIO-SDK-PROVIDER"; + public static final String LOGGER_IDTYPE = "REGISTRATION / AUTH"; +} \ No newline at end of file diff --git a/biosdk-services/src/main/java/io/mosip/biosdk/services/impl/spec_1_0/BioSdkServiceProviderImpl_V_1_0.java b/biosdk-services/src/main/java/io/mosip/biosdk/services/impl/spec_1_0/BioSdkServiceProviderImpl_V_1_0.java index 48e69021..69a7c777 100644 --- a/biosdk-services/src/main/java/io/mosip/biosdk/services/impl/spec_1_0/BioSdkServiceProviderImpl_V_1_0.java +++ b/biosdk-services/src/main/java/io/mosip/biosdk/services/impl/spec_1_0/BioSdkServiceProviderImpl_V_1_0.java @@ -29,14 +29,15 @@ import io.mosip.kernel.core.logger.spi.Logger; @Component -public class BioSdkServiceProviderImpl_V_1_0 implements BioSdkServiceProvider { +public class BioSdkServiceProviderImpl_V_1_0 // NOSONAR + implements BioSdkServiceProvider { private Logger logger = LoggerConfig.logConfig(BioSdkServiceProviderImpl_V_1_0.class); private static final String BIOSDK_SERVICE_SPEC_VERSION = "1.0"; private static final String INIT = "init"; private static final String CHECK_QUALITY = "checkQuality"; - private static final String EXTRACT_TEMPLATE = "extractTemplate"; + private static final String EXTRACT_TEMPLATE = "extractTemplate"; private static final String MATCH = "match"; private static final String SEGMENT = "segment"; private static final String CONVERT_FORMAT = "convertFormat"; @@ -57,7 +58,7 @@ public BioSdkServiceProviderImpl_V_1_0(IBioApiV2 iBioApi, Utils utils) { this.utils = utils; gson = new GsonBuilder().serializeNulls().create(); } - + @Override public String getSpecVersion() { return BIOSDK_SERVICE_SPEC_VERSION; @@ -188,7 +189,8 @@ public Object convertFormat(RequestDto request) { private void logRequest(ExtractTemplateRequestDto extractTemplateRequestDto) { if (isLogRequestResponse) { - logger.debug(LOGGER_SESSIONID, LOGGER_IDTYPE, "REQUEST::ExtractTemplateRequestDto", utils.toString(extractTemplateRequestDto)); + logger.debug(LOGGER_SESSIONID, LOGGER_IDTYPE, "REQUEST::ExtractTemplateRequestDto", + utils.toString(extractTemplateRequestDto)); } } @@ -206,19 +208,22 @@ private void logRequest(InitRequestDto initRequestDto) { private void logRequest(CheckQualityRequestDto checkQualityRequestDto) { if (isLogRequestResponse) { - logger.debug(LOGGER_SESSIONID, LOGGER_IDTYPE, "REQUEST:: CheckQualityRequestDto", utils.toString(checkQualityRequestDto)); + logger.debug(LOGGER_SESSIONID, LOGGER_IDTYPE, "REQUEST:: CheckQualityRequestDto", + utils.toString(checkQualityRequestDto)); } } private void logRequest(SegmentRequestDto segmentRequestDto) { if (isLogRequestResponse) { - logger.debug(LOGGER_SESSIONID, LOGGER_IDTYPE, "REQUEST:: SegmentRequestDto", utils.toString(segmentRequestDto)); + logger.debug(LOGGER_SESSIONID, LOGGER_IDTYPE, "REQUEST:: SegmentRequestDto", + utils.toString(segmentRequestDto)); } } private void logRequest(ConvertFormatRequestDto convertFormatRequestDto) { if (isLogRequestResponse) { - logger.debug(LOGGER_SESSIONID, LOGGER_IDTYPE, "REQUEST:: ConvertFormatRequestDto", utils.toString(convertFormatRequestDto)); + logger.debug(LOGGER_SESSIONID, LOGGER_IDTYPE, "REQUEST:: ConvertFormatRequestDto", + utils.toString(convertFormatRequestDto)); } } diff --git a/biosdk-services/src/main/java/io/mosip/biosdk/services/utils/ErrorCode.java b/biosdk-services/src/main/java/io/mosip/biosdk/services/utils/ErrorCode.java index 53e8f91f..c7054357 100644 --- a/biosdk-services/src/main/java/io/mosip/biosdk/services/utils/ErrorCode.java +++ b/biosdk-services/src/main/java/io/mosip/biosdk/services/utils/ErrorCode.java @@ -4,7 +4,7 @@ public enum ErrorCode { NO_PROVIDERS("BIO_SDK_001", "No Bio SDK service provider implementations found for given version"); - private String errorCode; + private String errorCode; // NOSONAR private String errorMessage; ErrorCode(String errorCode, String errorMessage) {