Add travis badge in README #7

Merged
merged 1 commit into from Sep 16, 2013

Conversation

Projects
None yet
2 participants
@xKerman
Contributor

xKerman commented Sep 15, 2013

It'd look really nice if we could see the status of MoSQL, so I added Travis CI badge in README.rst.

Example is (badge is at the bottom):
https://github.com/xKerman/mosql/blob/add-travis-spike/README.rst

@moskytw

This comment has been minimized.

Show comment
Hide comment
@moskytw

moskytw Sep 16, 2013

Owner

I have few questions about it.

  1. Is it possible to don't use tox as dependence, or it is necessary for Travis CI?
  2. Actually, python archived/tests/unittest/unittest_all.py is not the approach to do test anymore, so it is why I put it into archived dir. I use make doctest in docs folder now. Is it possible to use it to do test?

it is a cool stuff. I just want to add it. Thank you. :)

Owner

moskytw commented Sep 16, 2013

I have few questions about it.

  1. Is it possible to don't use tox as dependence, or it is necessary for Travis CI?
  2. Actually, python archived/tests/unittest/unittest_all.py is not the approach to do test anymore, so it is why I put it into archived dir. I use make doctest in docs folder now. Is it possible to use it to do test?

it is a cool stuff. I just want to add it. Thank you. :)

@xKerman

This comment has been minimized.

Show comment
Hide comment
@xKerman

xKerman Sep 16, 2013

Contributor
  1. Yes, it is possible. Tox is useful module when we test python module for multiple python version, but in this case it is not necessary, and it is also not required in Travis CI environment. So we can remove that dependency.

  2. Yes, it is possible to use make doctest as test command. Actually, we can use any command for the test if following requirements are met:

  • When the test succeeds, then exit with 0 status code
  • When the test fails, then exit with other status code

make doctest command meets the above requirements, so we can use this command as test command in Travis CI.

Further details are:

I removed tox dependency and fixed to use make doctest for testing.
Could you review again this pull request? Thnaks.

Contributor

xKerman commented Sep 16, 2013

  1. Yes, it is possible. Tox is useful module when we test python module for multiple python version, but in this case it is not necessary, and it is also not required in Travis CI environment. So we can remove that dependency.

  2. Yes, it is possible to use make doctest as test command. Actually, we can use any command for the test if following requirements are met:

  • When the test succeeds, then exit with 0 status code
  • When the test fails, then exit with other status code

make doctest command meets the above requirements, so we can use this command as test command in Travis CI.

Further details are:

I removed tox dependency and fixed to use make doctest for testing.
Could you review again this pull request? Thnaks.

moskytw added a commit that referenced this pull request Sep 16, 2013

@moskytw moskytw merged commit e8c6285 into moskytw:dev Sep 16, 2013

@moskytw

This comment has been minimized.

Show comment
Hide comment
@moskytw

moskytw Sep 16, 2013

Owner

Thanks for your kind answer. It is perfect now. I just merged it. :)

Owner

moskytw commented Sep 16, 2013

Thanks for your kind answer. It is perfect now. I just merged it. :)

@xKerman xKerman deleted the xKerman:add-travis-badge branch Sep 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment