Skip to content

Commit b90fe85

Browse files
committed
fix: don't wait for process completion when clicking links
Do not wait for processes to exit when executing commands. Otherwise pacseek will freeze if the browser is not yet running. Signed-off-by: moson-mo <mo-son@mailbox.org>
1 parent b662669 commit b90fe85

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

internal/pacseek/display.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ func (ps *UI) displayHelp() {
256256
Color: tcell.ColorWhite,
257257
BackgroundColor: tcell.ColorBlack,
258258
Clicked: func() bool {
259-
exec.Command("xdg-open", "https://github.com/moson-mo/pacseek/wiki/Usage").Run()
259+
exec.Command("xdg-open", "https://github.com/moson-mo/pacseek/wiki/Usage").Start()
260260
return true
261261
},
262262
})

internal/pacseek/draw.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ func (ps *UI) drawPackageInfo(i InfoRecord, width int) {
270270
}
271271
if strings.Contains(k, "URL") {
272272
cell.SetClickedFunc(func() bool {
273-
exec.Command("xdg-open", v).Run()
273+
exec.Command("xdg-open", v).Start()
274274
return true
275275
})
276276
}
@@ -382,7 +382,7 @@ func (ps *UI) drawNews() {
382382
ps.tableNews.SetCell(r, 0, &tview.TableCell{
383383
Text: "[white:black:]* [::u]" + item.Title,
384384
Clicked: func() bool {
385-
exec.Command("xdg-open", item.Link).Run()
385+
exec.Command("xdg-open", item.Link).Start()
386386
return true
387387
},
388388
}).

internal/pacseek/setup.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ func (ps *UI) setupKeyBindings() {
275275

276276
// CTRL+O - Open URL for selected package
277277
if event.Key() == tcell.KeyCtrlO && ps.selectedPackage != nil {
278-
exec.Command("xdg-open", ps.selectedPackage.URL).Run()
278+
exec.Command("xdg-open", ps.selectedPackage.URL).Start()
279279
return nil
280280
}
281281

0 commit comments

Comments
 (0)