Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

PluginManager: described two bugs.

Will fix them later (hopefully).
  • Loading branch information...
commit 8135f3668fbf51de137e93fde3f9a50b9c5b529c 1 parent eba9601
@mosra authored
View
2  src/PluginManager/AbstractPlugin.h
@@ -77,6 +77,8 @@ class CORRADE_PLUGINMANAGER_EXPORT AbstractPlugin {
* Note that this function might be called subsequently more than once
* (e.g. when loading derived plugin after the base plugin has been
* already initialized).
+ * @bug ^ this will fail for base plugin if derived plugin is unloaded
+ * and base plugin is still used
*/
static void finalize();
View
5 src/PluginManager/AbstractPluginManager.cpp
@@ -105,6 +105,11 @@ AbstractPluginManager::~AbstractPluginManager() {
/* Plugin doesn't belong to this manager */
if(it->second->manager != this) continue;
+ /**
+ * @bug When two plugins depend on each other and the base is unloaded
+ * first, it fails (but it shouldn't)
+ */
+
/* Unload the plugin */
LoadState loadState = unload(it->first);
CORRADE_ASSERT(loadState & (LoadState::Static|LoadState::NotLoaded|LoadState::WrongMetadataFile),
Please sign in to comment.
Something went wrong with that request. Please try again.