New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors with BUILD_DEPRECIATED=OFF #24

Closed
ghost opened this Issue Jul 3, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@ghost

ghost commented Jul 3, 2016

With GCC 5.3.1 (default on Ubuntu 16.04), the following errors occur if BUILD_DEPRECIATED=OFF

/home/ren/Desktop/ArcAngel2D/corrade/src/Corrade/Utility/utilities.h:66:26: error: ISO C++ forbids declaration of ‘CORRADE_DEPRECATED’ with no type [-fpermissive]
inline CORRADE_DEPRECATED("Use System::sleep() instead") void sleep(std::size_t ms) {
^
/home/ren/Desktop/ArcAngel2D/corrade/src/Corrade/Utility/utilities.h:66:26: error: ‘Corrade::Utility::CORRADE_DEPRECATED’ declared as an ‘inline’ variable
/home/ren/Desktop/ArcAngel2D/corrade/src/Corrade/Utility/utilities.h:66:56: error: invalid conversion from ‘const char*’ to ‘int’ [-fpermissive]
inline CORRADE_DEPRECATED("Use System::sleep() instead") void sleep(std::size_t ms) {
^
/home/ren/Desktop/ArcAngel2D/corrade/src/Corrade/Utility/utilities.h:66:58: error: expected ‘,’ or ‘;’ before ‘void’
inline CORRADE_DEPRECATED("Use System::sleep() instead") void sleep(std::size_t ms) {
^

Looks like -Wno-permissive would fix it, but it looks like GCC is getting smart enough to get around CORRADE_DEPRECATED logic.

@mosra

This comment has been minimized.

Show comment
Hide comment
@mosra

mosra Jul 4, 2016

Owner

Sorry about this, forgot to #ifdef the deprecated API properly. Fixed in 9c345e3, similar issues were fixed in mosra/magnum@9b74425.

Seems like I'm getting old and forgetful.

Owner

mosra commented Jul 4, 2016

Sorry about this, forgot to #ifdef the deprecated API properly. Fixed in 9c345e3, similar issues were fixed in mosra/magnum@9b74425.

Seems like I'm getting old and forgetful.

@mosra mosra closed this Jul 4, 2016

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment