Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORRADE_DEPRECATED_*() macros don't really work on MSVC2015 #46

Closed
mosra opened this issue May 30, 2018 · 1 comment

Comments

Projects
1 participant
@mosra
Copy link
Owner

commented May 30, 2018

Reported by @AVK330.

  • Using __declspec instead of [[]] might make it working in some cases but might require a different placement in other cases (in that case the macro would need to be completely no-op on 2015). nope
  • Verify that the other macros work properly (it seems that the test doesn't trigger deprecation warning for structs) well, partly
  • Verify the same on MSVC2017 and GCC (I think there are also some bad cases) -- yes.

@mosra mosra added this to the 2018.0c milestone May 30, 2018

@mosra mosra self-assigned this May 30, 2018

@mosra mosra added this to TODO in Utility via automation May 30, 2018

@mosra mosra modified the milestones: 2018.0c, 2018.1d Oct 15, 2018

@mosra mosra removed this from the 2019.01 milestone Jan 29, 2019

@mosra mosra added this to the 2019.0b milestone Mar 15, 2019

@mosra

This comment has been minimized.

Copy link
Owner Author

commented Mar 16, 2019

Looked at this, and ... the support is spotty at best, deprecation warnings emitted only in some cases but not all (and can't really do anything about that, compiler limitations). The docs are updated to mention these in 229693f, Also online.

@mosra mosra closed this Mar 16, 2019

Utility automation moved this from TODO to Done Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.