Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conan: Wrong version checked for "MSVC2017_COMPATIBILITY" #93

Closed
helmesjo opened this issue Apr 5, 2020 · 3 comments
Closed

conan: Wrong version checked for "MSVC2017_COMPATIBILITY" #93

helmesjo opened this issue Apr 5, 2020 · 3 comments
Labels
changelog mention added
Milestone
2020.06

Comments

@helmesjo
Copy link
Contributor

helmesjo commented Apr 5, 2020

corrade/conanfile.py

Line 102 in f08be26

add_cmake_option("MSVC2017_COMPATIBILITY", int(self.settings.compiler.version.value) == 17)

Just noticed this while glancing over. It should be 15, right?

Disclaimer: It has it's origin from my recipe... :D
@mosra
Copy link
Owner

mosra commented Apr 5, 2020

Isn't it 14.1? I don't know which of the seven versioning schemes Conan uses :) https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering

@helmesjo
Copy link
Contributor Author

helmesjo commented Apr 6, 2020

Haha yep, that is a wild ride for sure. It should be the right (:point_right:) one.
🙃

@mosra mosra added this to the 2020.0a milestone Apr 6, 2020
@mosra
Copy link
Owner

mosra commented Apr 6, 2020

Fixed in c037414, also added the MSVC2019_COMPATIBILITY option that is new since last time.

@mosra mosra closed this as completed Apr 6, 2020
@mosra mosra moved this to Done in Corrade / Platforms Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog mention added
Projects
Corrade / Platforms
Status: Done
Milestone
2020.06
Development

No branches or pull requests
2 participants
@mosra @helmesjo