ci: Move emscripten to ubuntu docker builds #105
Conversation
Squareys
force-pushed
the
switch-emsc-ci
branch
from
3f025d8 to
9df5078
Compare
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 98 98
Lines 7193 7193
=======================================
Hits 7018 7018
Misses 175 175 Continue to review full report at Codecov.
|
Squareys
force-pushed
the
switch-emsc-ci
branch
6 times, most recently
from
18be680 to
7e53641
Compare
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
switch-emsc-ci
branch
from
bccabc7 to
9654456
Compare
Squareys
changed the title
|
@mosra Ready for review/merge! :) |
| wget https://github.com/ninja-build/ninja/releases/download/v1.8.2/ninja-linux.zip | ||
| unzip ninja-linux.zip | ||
| mv ninja /usr/local/bin/ | ||
| ninja --version |
There was a problem hiding this comment.
Heh. I suppose apt install ninja just doesn't work on docker, right?
There was a problem hiding this comment.
Oh, actually sure, that would work, if there's a package (I assume it's called ninja-build, though?)
There was a problem hiding this comment.
In the yml it's listed among the packages, but I think it's ninja-build, yes.
| # Using whatever is the default, since that could be hopefully most | ||
| # up-to-date | ||
| env: | ||
| - JOBID=emscripten | ||
| - TARGET=emscripten | ||
| - EMSCRIPTEN_VERSION=2.0.7 |
There was a problem hiding this comment.
I want to test on the oldest version available, ideally exactly what was there on Mac (1.38.42)
There was a problem hiding this comment.
The docker image supports everything above 1.39.0, 1.38.42 is pretty ancient
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG -O1" \ | ||
| -DCMAKE_INSTALL_PREFIX=$HOME/deps \ | ||
| -DCMAKE_EXE_LINKER_FLAGS_RELEASE="-O1" \ | ||
| -DBUILD_TESTS=ON \ | ||
| -G Ninja | ||
| ninja -j4 | ||
| ninja -j2 |
There was a problem hiding this comment.
Just ninja, it should figure out the cores on its own.
I faintly remember I had to do this because otherwise at some point it was running 8 jobs at once, running out of memory. Probably not an issue nowadays anymore.
|
Travis forced me to a extremely limited trial plan way sooner than I expected, so this is critically important now. Merged as 824a74c, this one build cost me 1120 credits out of the 10k, the build on master will be another 1120 and then I have maybe one Magnum build left and there we are. |
Hi @mosra !
This is an initial test to switch to the emscripten docker image with ubuntu base image.
Best,
Jonathan