Utility: more argv const in Arguments::parse #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthalik
force-pushed
the
pr/parse-argv-const
branch
from
77b1d14
to
82ee618
Compare
mosra
reviewed
Jun 11, 2022
src/Corrade/Utility/Arguments.h
Outdated
| @@ -873,7 +863,7 @@ class CORRADE_UTILITY_EXPORT Arguments { | |||
| * additional arguments are parsed, only `--help` option is set and | |||
| * @cpp true @ce is returned. | |||
| */ | |||
| bool tryParse(int argc, const char** argv); | |||
| bool tryParse(int argc, const char* const* argv); | |||
|
|
|||
| /** @overload */ | |||
| bool tryParse(int argc, char** argv) { | |||
There was a problem hiding this comment.
Can you drop these as well? Thank you! 😊
sthalik
force-pushed
the
pr/parse-argv-const
branch
from
82ee618
to
a7da501
Compare
|
PR with a net negative line count is never bad :D Thank you. Now I need to look where else I forgot to realize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.