Add missing noexcept for some move ctors/assigns #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
force-pushed
the
add-no-except
branch
2 times, most recently
from
80e7fb9 to
ce89338
Compare
Skylion007
force-pushed
the
add-no-except
branch
from
ce89338 to
58877fe
Compare
|
@mosra This PR should be good to go. |
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 133 133
Lines 10855 10855
=======================================
Hits 10632 10632
Misses 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Yeah I was neglecting these because the whole Configuration API is due for a serious redesign :) Thanks in any case.
Just to correct here a bit -- the asserts are not exceptions (they're aborting), and thus can appear in |
|
Argh GitHub UI what are you doing. Merged as 1d214f6 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied some fixes with the latest clang-tidy tools to Corrade. Mainly some missing noexcept specifies for move assignments, which will allow it to use move operations in STL containers.
LinkedLIst could also have some methods marked as noexcept, although they would not actually be noexcept with CORRADE_ASSERTS (in debug mode). They are noexcept in Release Mode though.