Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debuggers: move license comment in MSVC natvis file into the root #160

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

pezcode
Copy link
Contributor

@pezcode pezcode commented Dec 9, 2022

XML doesn't allow having anything before the root, and MSVC being diligent refuses to parse the .natvis file

…ment.

XML doesn't allow anything before the root, and Visual Studio fails to
parse the .natvis
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 97.96% // Head: 97.96% // No change to project coverage 👍

Coverage data is based on head (ef9806c) compared to base (8a5a395).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         135      135           
  Lines       11053    11053           
=======================================
  Hits        10828    10828           
  Misses        225      225           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mosra mosra merged commit ef9806c into mosra:master Dec 9, 2022
@mosra
Copy link
Owner

mosra commented Dec 9, 2022

Whoops. Interesting spec requirement, didn't know about it myself. Sorry for the mess up.

@mosra mosra added this to the 2022.0a milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants