debuggers: move license comment in MSVC natvis file into the root#160
Merged
Conversation
…ment. XML doesn't allow anything before the root, and Visual Studio fails to parse the .natvis
Codecov ReportBase: 97.96% // Head: 97.96% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 135 135
Lines 11053 11053
=======================================
Hits 10828 10828
Misses 225 225 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Owner
|
Whoops. Interesting spec requirement, didn't know about it myself. Sorry for the mess up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XML doesn't allow having anything before the root, and MSVC being diligent refuses to parse the .natvis file