Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debuggers: adapt MSVC natvis to recent String changes #165

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

pezcode
Copy link
Contributor

@pezcode pezcode commented Jan 19, 2023

Small fix to make the .natvis file work with current master again 🍒 And I made MSVC show you whether a string is small-size-optimized or not, sometimes handy to know.

@mosra mosra added this to the 2022.0a milestone Jan 19, 2023
@mosra
Copy link
Owner

mosra commented Jan 19, 2023

Thank you!

Which reminds me, the GDB pretty-printers should probably get an update as well -- @williamjcm, is that something you'd have time for? Thanks as well!

@williamjcm
Copy link
Contributor

I do have time for it.

Out of curiosity, were there any other changes in Corrade that could affect the printers ?

@mosra
Copy link
Owner

mosra commented Jan 19, 2023

Thank you!

There's a new Iterable and StringIterable containers that got added since you made the original PR in August, and I'll add a StridedBitArrayView (and possibly StaticBitArray) soon to have a bit-sized complement for all the most important Array[View] types. Apart from that, the change to StringView internals was the only that would be breaking anything, I don't remember anything else.

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 97.98% // Head: 97.98% // No change to project coverage 👍

Coverage data is based on head (a47058e) compared to base (8effd9c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         136      136           
  Lines       11150    11150           
=======================================
  Hits        10925    10925           
  Misses        225      225           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mosra mosra merged commit a47058e into mosra:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants