New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interconnect: Use () instead of {} in constructor because of MSVC. #28

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
3 participants
@Squareys
Contributor

Squareys commented Aug 11, 2016

Hi @mosra !

It's one of these again!

This just popped up today. On MSVC I got a syntax error trying to compile Corrade::Interconnect.
A collegue reported ee4bbeb to compile fine (a few later may also work).

I found out that this is one of the cases where MSVC did not like the {} while calling a superconstructor.
Since the CI compiled without complaints, I am guessing this may be fine with "Visual Studio Update 3"?
I will install that and report back whether that compiles without this change.

Greetings, Squareys.

Interconnect: Use () instead of {} in constructor because of MSVC.
Signed-off-by: Squareys <Squareys@googlemail.com>
@coveralls

This comment has been minimized.

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 93.906% when pulling 5634fd8 on Squareys:fix-interconnect-msvc-build into 8ed0209 on mosra:master.

@Squareys

This comment has been minimized.

Contributor

Squareys commented Aug 11, 2016

Alright, so "Visual Studio Update 3" fixed the problem.

@mosra mosra merged commit 5634fd8 into mosra:master Aug 16, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.906%
Details
@mosra

This comment has been minimized.

Owner

mosra commented Aug 16, 2016

Merged, thanks!

(Even though I'll update the min MSVC requirements to Update 3 later.)

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment