New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issue related to CORRADE_NORETURN being undefined #32

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
3 participants
@alicemargatroid
Contributor

alicemargatroid commented Mar 19, 2017

CORRADE_NORETURN is defined in the Macros.h file, which is not included by Debug.h.
Adding it back restores compilability on modern versions of GCC/Clang

@coveralls

This comment has been minimized.

coveralls commented Mar 19, 2017

Coverage Status

Coverage remained the same at 95.953% when pulling 66fe750 on alicemargatroid:master into 1641f48 on mosra:master.

@alicemargatroid

This comment has been minimized.

Contributor

alicemargatroid commented Mar 20, 2017

@mosra I doubt my addition of a header is causing IOS to break unit tests, so I hope this can be merged quickly.

@mosra mosra merged commit 66fe750 into mosra:master Mar 20, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 95.953%
Details
@mosra

This comment has been minimized.

Owner

mosra commented Mar 20, 2017

Thank you!

Sorry for this. I see that this error pops out when compiling w/o deprecated features, which I somehow failed to test properly recently. I will add a special CI build just to cover the case of building w/o deprecated features, because I'm certain there are similar situations in other repositories as well.

Also I'm on fixing the iOS build -- there's some weird linker error and xcpretty failed in propagating the exit code so the build happily continued with running nonexistent unit tests :D

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment