-
Notifications
You must be signed in to change notification settings - Fork 111
Packages: Add Conan support #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Major work done by @helmesjo, thanks! Co-Authored-By: helmesjo <helmesjo@live.com>
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 78 78
Lines 5020 5020
=======================================
Hits 4922 4922
Misses 98 98 Continue to review full report at Codecov.
|
Builds fine and installed files look correct! 🎉 Also diffed against my |
Thanks a lot! So if I understand correctly, this should get in before the 2019.01 version is tagged, right? Will you be submitting a similar one for Magnum (should I wait?) or not?
Oh! Good to know, adding it to my release checklist. |
I will have a look if I'm able to get in done in time 😄 Should be doable I hope |
Yes, please |
Wonderful, thank you! One last thing: what should I put into the building docs re Conan? Something like above?
(it should have said |
I would rather recommend to put in the second command
It is good to know when the build step itself is successful, but the output is corrupt. The tests will complain if this should be the case :)
No, it is This create command results in the following full recipe path: |
- As Daniel Pfeifer and Mathieu Ropert said, language standard and GLOB should be avoided directly in CMakeLists.txt Signed-off-by: Uilian Ries <uilianries@gmail.com>
Squashed and merged in c32fbbb, thanks a lot! I removed the Regarding the corresponding Magnum package, I probably won't be tagging |
Major work done by @helmesjo, thanks!
Also please review @helmesjo that I didn't make something stupid when adopting your version of the recipe 😄
This is adding basic support for Conan. After merging this people can install and use Corrade by checking out this git repository and installing it via
conan create . magnum/stable
To make sure that the build was successful, the
test_package
should be executed in the same step viaconan create . magnum/stable -tf package/conan/test_package
(
-tf
stands for test folder)This is not yet adding any CI/CD logic, which is mass building packages for all kinds of configurations and uploading these to a Conan repository. This should follow at a later step. In the meantime the Conan create command is always building Corrade from source automatically, as Conan is always doing when there aren't pre-build packages available for the own configuration.
Please don't forget to update the version number in the
conanfile.py
file before tagging a new release. In the future we can eliminate the hard coded version in theconanfile.py
, but for now this makes things easier.Cross-referencing: mosra/magnum#304