Skip to content

Directory: Close files on copy() failure - #70

Closed
Squareys wants to merge 1 commit into
mosra:masterfrom
Squareys:patch-2
Closed

Squareys wants to merge 1 commit into
mosra:masterfrom
Squareys:patch-2

Conversation

@Squareys

Copy link
Copy Markdown
Contributor

Hi @mosra !

As mentioned per gitter :)

Cheers, Jonathan.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #70 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   97.61%   97.61%   +<.01%     
==========================================
  Files          80       80              
  Lines        5455     5457       +2     
==========================================
+ Hits         5325     5327       +2     
  Misses        130      130
Impacted Files Coverage Δ
src/Corrade/Utility/Directory.cpp 88.54% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f9ee0...8ec07db. Read the comment docs.

1 similar comment
@codecov-io

codecov-io commented Jun 23, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #70 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   97.61%   97.61%   +<.01%     
==========================================
  Files          80       80              
  Lines        5455     5457       +2     
==========================================
+ Hits         5325     5327       +2     
  Misses        130      130
Impacted Files Coverage Δ
src/Corrade/Utility/Directory.cpp 88.54% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f9ee0...8ec07db. Read the comment docs.

@mosra

mosra commented Jun 26, 2019

Copy link
Copy Markdown
Owner

I fixed this in 132fd6f by moving the scope guards up. Less code generated :)

(well, I hope that doesn't miss anything obvious compared to your patch)

@mosra mosra closed this Jun 26, 2019
@mosra mosra added this to the 2019.0b milestone Jun 26, 2019
@Squareys

Copy link
Copy Markdown
Contributor Author

@mosra Looks great! Just the 2015 copyright year in the header is a little confusing ;)

@mosra

mosra commented Jun 27, 2019

Copy link
Copy Markdown
Owner

argh! bad, copypaste, bad 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants