Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory: Close files on copy() failure #70

Closed
wants to merge 1 commit into from

Conversation

Projects
3 participants
@Squareys
Copy link
Contributor

commented Jun 23, 2019

Hi @mosra !

As mentioned per gitter :)

Cheers, Jonathan.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 23, 2019

Codecov Report

Merging #70 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   97.61%   97.61%   +<.01%     
==========================================
  Files          80       80              
  Lines        5455     5457       +2     
==========================================
+ Hits         5325     5327       +2     
  Misses        130      130
Impacted Files Coverage Δ
src/Corrade/Utility/Directory.cpp 88.54% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f9ee0...8ec07db. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented Jun 23, 2019

Codecov Report

Merging #70 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   97.61%   97.61%   +<.01%     
==========================================
  Files          80       80              
  Lines        5455     5457       +2     
==========================================
+ Hits         5325     5327       +2     
  Misses        130      130
Impacted Files Coverage Δ
src/Corrade/Utility/Directory.cpp 88.54% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f9ee0...8ec07db. Read the comment docs.

@mosra

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2019

I fixed this in 132fd6f by moving the scope guards up. Less code generated :)

(well, I hope that doesn't miss anything obvious compared to your patch)

@mosra mosra closed this Jun 26, 2019

@mosra mosra added this to the 2019.0b milestone Jun 26, 2019

@mosra mosra added this to TODO in Utility via automation Jun 26, 2019

@mosra mosra moved this from TODO to Done in Utility Jun 26, 2019

@Squareys

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

@mosra Looks great! Just the 2015 copyright year in the header is a little confusing ;)

@mosra

This comment has been minimized.

Copy link
Owner

commented Jun 27, 2019

argh! bad, copypaste, bad 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.