Skip to content

Utility/Directory: fix documentation for path()#71

Merged
mosra merged 1 commit intomosra:masterfrom
xqms:directory_path_doc
Jun 26, 2019
Merged

Utility/Directory: fix documentation for path()#71
mosra merged 1 commit intomosra:masterfrom
xqms:directory_path_doc

Conversation

@xqms
Copy link
Copy Markdown
Contributor

@xqms xqms commented Jun 26, 2019

The method returns everything before the last slash in the string.

The method returns everything before the *last* slash in the string.
@mosra mosra added this to the 2019.0b milestone Jun 26, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 26, 2019

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          80       80           
  Lines        5455     5455           
=======================================
  Hits         5325     5325           
  Misses        130      130
Impacted Files Coverage Δ
src/Corrade/Utility/Directory.h 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f9ee0...c29ef1b. Read the comment docs.

@mosra mosra merged commit c29ef1b into mosra:master Jun 26, 2019
@mosra
Copy link
Copy Markdown
Owner

mosra commented Jun 26, 2019

🤦‍♂️ thanks! 😆

@xqms
Copy link
Copy Markdown
Contributor Author

xqms commented Jun 27, 2019

One of the more fun PRs so far! You had me thinking for a moment, trying to find out in what weird context that functionality would be useful, before I looked into the source 😆
It's really a compliment to the quality of the API documentation that I trust it that much.

@xqms xqms deleted the directory_path_doc branch June 27, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants