Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility/Directory: fix documentation for path() #71

Merged
merged 1 commit into from Jun 26, 2019

Conversation

Projects
3 participants
@xqms
Copy link
Contributor

commented Jun 26, 2019

The method returns everything before the last slash in the string.

Utility/Directory: fix documentation for path()
The method returns everything before the *last* slash in the string.

@mosra mosra added this to the 2019.0b milestone Jun 26, 2019

@mosra mosra added this to TODO in Utility via automation Jun 26, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          80       80           
  Lines        5455     5455           
=======================================
  Hits         5325     5325           
  Misses        130      130
Impacted Files Coverage Δ
src/Corrade/Utility/Directory.h 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f9ee0...c29ef1b. Read the comment docs.

@mosra mosra merged commit c29ef1b into mosra:master Jun 26, 2019

5 checks passed

LGTM analysis: C/C++ No new or fixed alerts
Details
codecov/patch Coverage not affected when comparing 85f9ee0...c29ef1b
Details
codecov/project 97.61% remains the same compared to 85f9ee0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Utility automation moved this from TODO to Done Jun 26, 2019

@mosra

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2019

🤦‍♂ thanks! 😆

@xqms

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

One of the more fun PRs so far! You had me thinking for a moment, trying to find out in what weird context that functionality would be useful, before I looked into the source 😆
It's really a compliment to the quality of the API documentation that I trust it that much.

@xqms xqms deleted the xqms:directory_path_doc branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.