Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseCorrade.cmake: fixing .metadata's output directory #74

Closed
wants to merge 1 commit into from

Conversation

@xiconxi
Copy link
Contributor

commented Aug 14, 2019

UseCorrade.cmake: fixing custom-target<*.metadata> whileCMAKE_LIBRARY_OUTPUT_DIRECTORY is setted

@mosra mosra added this to the 2019.0b milestone Aug 16, 2019

@mosra

This comment has been minimized.

Copy link
Owner

commented Aug 16, 2019

Hi, thank you for the contribution!

I wonder, would this work also if $<TARGET_FILE_DIR:${plugin_name}> was used instead of ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}? That would fix it to not require the extra branch.

The other function, corrade_create_plugins_symlink_for_executable(), is not used from any place and I think it could live in your codebase for now instead? As I mentioned in another issue, making this work better is on my list, so when that's done, this function shouldn't be needed anymore.

@mosra mosra added this to TODO in Plugin manager via automation Aug 16, 2019

@xiconxi

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

I haven't use cmake-generator-expressions before, that's much better than mine。

@xiconxi xiconxi closed this Aug 19, 2019

Plugin manager automation moved this from TODO to Done Aug 19, 2019

@mosra

This comment has been minimized.

Copy link
Owner

commented Aug 20, 2019

Commited in bb45552, hopefully it works for you the way it should :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.