modules: Fix test command when library output path is set #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squareys
force-pushed
the
use-corrade-with-library-path
branch
from
77102ed
to
8cc50fe
Compare
cmake what the hell. Can you add a changelog entry as well so I don't have to? :) |
|
Sure!
That's documented, though :D |
|
I mean, I see no reason at all why the shorthand version would need to behave so differently. |
E.g. when `LIBRARY_OUTPUT_PATH` is set globally or the target property `LIBRARY_OUTPUT_DIRECTORY` is set. add_test(<name> <command> <args>) does not resolve the target file, but rather just runs the command, which works as long as it is where cmake puts in by default, but not if the library output dir is modified. add_test(NAME <name> COMMAND <command> <args>) on the other hand resolves generator expressions and <command>, if an executable target, will "automatically be replaced by the location of the executable created at build time." (from the cmake docs.) Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
use-corrade-with-library-path
branch
from
8cc50fe
to
114e58d
Compare
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 86 86
Lines 5732 5732
=======================================
Hits 5604 5604
Misses 128 128Continue to review full report at Codecov.
|
|
Done ✔️ |
|
Merged as 9298434, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mosra !
This is a tiny one, but would help me with maintenance a bit if it were to be upstreamed :)
Best,
Jonathan
From the commit message: