Directory: Print an error when mkpath() returns false #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squareys
changed the title
Squareys
changed the title
Squareys
force-pushed
the
mkpath-errors
branch
2 times, most recently
from
3dcf652
to
5ddde7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 97.41% 97.42% +<.01%
==========================================
Files 93 94 +1
Lines 6545 6559 +14
==========================================
+ Hits 6376 6390 +14
Misses 169 169
Continue to review full report at Codecov.
|
mosra
reviewed
Mar 14, 2020
Squareys
force-pushed
the
mkpath-errors
branch
2 times, most recently
from
2efac50
to
2ba456c
Compare
mosra
reviewed
Mar 14, 2020
Squareys
changed the title
Squareys
force-pushed
the
mkpath-errors
branch
5 times, most recently
from
b4bc900
to
5c09200
Compare
|
@mosra I fixed the final CI error, awaiting it's completion, then this is ready again. |
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mosra,
as discussed per gitter, here's the PR that adds some error messages to failures in
Directory::mkpath().Cheers,
Jonathan