[MinGW/Clang] Fix SEGFAULTs when logging to globals #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosra
reviewed
May 4, 2020
Co-authored-by: Vladimír Vondruš <mosra@centrum.cz>
Luck and perseverance I guess... Classic MinGW developper's traits right here xD |
|
Merged as abfeeaf, thank you! (The CIs take ages to go through, sorry.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I think I found the issue with mosra/magnum#417.
Changing few lines in
src/Corrade/Utility/Debug.cppallowed me to boot up a sample projet using a Magnum Clang build.My 2cts guess here is that Clang does some optimizations and "hard stores" pointer addresses of the standard outputs when directly referenced "as it", references that may change outside of Corrade, resulting in SEGFAULTs when Magnum tries to use its logging capabilities.