Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build on VS2019 #18

Closed
UNDEFINED-BEHAVIOR opened this issue Apr 21, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@UNDEFINED-BEHAVIOR
Copy link

commented Apr 21, 2019

I've been trying to build a minimal program (branch: base) using these instructions
https://github.com/mosra/magnum-bootstrap
https://doc.magnum.graphics/magnum/getting-started.html
but gotten stuck on errors posted below:

image

This one goes away after removing constexpr qualifier. (should this be ignored?)

image

I've tracked down the issue to MagnumGL project failing to build but still couldn't pinpoint the exact problem. What did I miss?

environment:
windows,
VS2019
clang (v142) (LLVM 8.0)
Debug, x64
cmake setting:
WITH_SDL2APPLICATION=ON
set(CMAKE_CXX_STANDARD 17)

Corrade, magnum were installed as submodule.
both checked out @ tag 2019.01

@mosra

This comment has been minimized.

Copy link
Owner

commented Apr 21, 2019

VS2019

Hi! Sorry to disappoint -- the codebase hasn't been tested against / adapted to VS 2019 yet and all the errors you're seeing are because of that. There is a slight chance things could start to work when you set MSVC2017_COMPATIBILITY to ON (it's a CMake option in Corrade), but I am not 100% betting on that -- so far, with every release of VS there were always new and exciting bugs to work around, so just applying the MSVC2017 workarounds to 2019 might not be enough.

I'll be definitely looking into this and ensuring things work correctly with VS 2019 but right now other things have a priority. Is there a chance you could run on VS 2017 in the meantime?

@UNDEFINED-BEHAVIOR

This comment has been minimized.

Copy link
Author

commented Apr 21, 2019

Thanks for the quick reply.

The MSVC2017_COMPATIBILITY flag apparently works! (at least on this bootstrap/example program) It compiles now but for MSVC compiler only. I've noticed that similar but different error pops up when using llvm tool chain on both 2017 and 2019.

Is clang supported on windows? or am I supposed to use it through mingw?
if not then I'm going to close this ticket now.

This is the clang for VS I'v been using:
https://github.com/zufuliu/llvm-utils

@mosra

This comment has been minimized.

Copy link
Owner

commented Apr 21, 2019

Someone tried Clang support some time ago (see mosra/magnum#227 and mosra/corrade#40), but nothing was done since so I guess you'll run into problems there too. MinGW + GCC is known to be working, Clang on other platforms (Linux, macOS, iOS, Android...) is working as well, but frankly I have no idea how it behaves on Windows.

Leave the ticket open as a reminder for me to fix the VS2019 support ;)

@mosra mosra changed the title Unable to build default bootstrap application. Unable to build on VS2019 Apr 21, 2019

@mosra mosra added this to the 2019.0b milestone Apr 21, 2019

@mosra mosra self-assigned this Apr 21, 2019

@mosra

This comment has been minimized.

Copy link
Owner

commented Jul 6, 2019

MSVC 2019 support done with mosra/corrade@161c9e0, mosra/magnum@ddb16f6, mosra/magnum@9e2a111 and mosra/magnum@d542e2b. Other packages (plugins, extras, integration, examples) don't seem to need any adjustments so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.