Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variabls #66

Closed
janbajana opened this issue Oct 7, 2019 · 3 comments
Closed

Undefined variabls #66

janbajana opened this issue Oct 7, 2019 · 3 comments

Comments

@janbajana
Copy link

@janbajana janbajana commented Oct 7, 2019

Hello guys,

after the last update to magnum "master" I got compilation errors If I build examples.
Did something change for magnum linking? This came after last pull. There is a ton of undefined types. Or I did something wrong?

example of the error:
e:\git\magnum-examples\src\shadows\shadowsexample.cpp(290): error C2027: use of undefined type 'Magnum::Math::Color3<Magnum::Float>'

My build script (tested Windows build):
https://github.com/janbajana/script-helpers/blob/master/cmake-scripts/setup-magnum-examples-build.sh

@mosra mosra added this to the 2019.0b milestone Oct 7, 2019
@mosra mosra added this to TODO in Project management via automation Oct 7, 2019
@mosra

This comment has been minimized.

Copy link
Owner

@mosra mosra commented Oct 7, 2019

Hi, sorry, this is because I pushed a header-hygiene commit to Magnum late last week (mosra/magnum@a0f0015) but didn't have time to update the depending projects for it yet. I'm on that today, will ping you once it's done :)

@janbajana

This comment has been minimized.

Copy link
Author

@janbajana janbajana commented Oct 7, 2019

Super. Thank you for the quick update.
Going back to previous commit 9616273 all is working. For now I happy with that :).

@mosra

This comment has been minimized.

Copy link
Owner

@mosra mosra commented Oct 8, 2019

With 76d2afa (and also mosra/magnum-integration@4431f9b and mosra/magnum-bindings@106ca8f), using master of everything should work again.

Just a note -- I'm doing a bunch of buildsystem-related changes to the repos in preparation for a stable release, so a few more similar issues might temporarily pop up over the next few days, until it settles down again -- such breakages are quite uncommon for this project.

@mosra mosra closed this Oct 8, 2019
Project management automation moved this from TODO to Done Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.