New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apdapt to Oculus SDK 0.6.0.1 #13

Merged
merged 4 commits into from Aug 1, 2015

Conversation

Projects
None yet
2 participants
@Squareys
Contributor

Squareys commented Aug 1, 2015

Hi @mosra !

the example required a minor change to compile with the adaptions of LibOvrIntegration to Oculus SDK 0.6.0.1 (mosra/magnum-integration#7).

I also added the performance hud to the example, which only works for real devices because of an sdk bug for now, though.

Greetings,
Squareys

Squareys added some commits Aug 1, 2015

ovr: Adapt to recent LibOvrIntegration changes.
Merely a single enum value is no longer required.

Signed-off-by: Squareys <Squareys@googlemail.com>
ovr: Fix formatting and javadoc of application class and namespaces.
Signed-off-by: Squareys <Squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:oculus-sdk-0.6.0.1 branch 2 times, most recently from 55568b0 to 9c76519 Aug 1, 2015

Squareys added some commits Aug 1, 2015

ovr: Show the performance HUD with F11.
Signed-off-by: Squareys <Squareys@googlemail.com>
ovr: Exit application on Esc.
Signed-off-by: Squareys <Squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:oculus-sdk-0.6.0.1 branch from 9c76519 to ce32da1 Aug 1, 2015

@Squareys

This comment has been minimized.

Owner

Squareys commented on d516bbc Aug 1, 2015

I considered someting along the lines of

    _curPerfHudMode++;
    if(_curPerfHudMode > 2) {
        _curPerfHudMode = PerformanceHudMode::Off;
    }

but decided against for 1. readability (it's and example after all) and 2. staying independent of the implementation of that enum.

This comment has been minimized.

mosra replied Aug 1, 2015

_curPerfHudMode = (_curPerfHudMode + 1) % 2;

Rather not, it's perfectly okay and readable the way it is now :)

This comment has been minimized.

Owner

Squareys replied Aug 1, 2015

That was what I thought of at first, but then my brain told me, modulo is less efficient than an if :P Not that it really makes a difference. Would have been % 3, of course.

@mosra mosra merged commit ce32da1 into mosra:master Aug 1, 2015

@mosra

This comment has been minimized.

Owner

mosra commented Aug 1, 2015

Merged, thanks again!

@Squareys

This comment has been minimized.

Contributor

Squareys commented Aug 1, 2015

Thank you, too!

@mosra mosra added this to the 2018.02 milestone Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment