New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovr: Adapt to recent OvrIntegration changes. #19

Merged
merged 5 commits into from Nov 30, 2015

Conversation

Projects
None yet
2 participants
@Squareys
Contributor

Squareys commented Nov 16, 2015

Hi @mosra !

With every pullrequest on OvrIntegration, there is one here, too. These are the changes to adapt to mosra/magnum-integration#10.

Greetings,
Squareys

Squareys added some commits Nov 16, 2015

modules: Update FindOVR.cmake.
Signed-off-by: Squareys <Squareys@googlemail.com>
ovr: Adapt to OvrIntegration changes.
Signed-off-by: Squareys <Squareys@googlemail.com>

@Squareys Squareys changed the title from ovr: Adapt ovr example to recent OvrIntegration changes. to ovr: Adapt to recent OvrIntegration changes. Nov 16, 2015

@Squareys Squareys referenced this pull request Nov 16, 2015

Closed

Update to Oculus SDK 0.8.0.0-beta #10

7 of 7 tasks complete
ovr: Use recommended TextureFormat.
Signed-off-by: Squareys <Squareys@googlemail.com>

@mosra mosra referenced this pull request Nov 24, 2015

Closed

Next release #108

34 of 34 tasks complete
@@ -5,9 +5,17 @@ This example demonstrates integration of the [Oculus SDK](http://developer.oculu
Notes
-----
This example requires you to have the Oculus Runtime 0.6.0.0-beta installed. Since Oculus
only supports Windows, the same holds for the example.
This example requires you to have the Oculus Runtime 0.7.0.0-beta or newer installed.

This comment has been minimized.

@mosra

mosra Nov 24, 2015

Owner

Just to be clear: this is not a typo and the example works with 0.7 too?

This comment has been minimized.

@Squareys

Squareys Nov 26, 2015

Contributor

Yes, supposedly it does, may even work with one of the 0.6 versions, I will double check. I believe it's due to the Service Architecture introduced back then, which makes these somewhat backwards compatible. May be the other way around, though :)

This comment has been minimized.

@Squareys

Squareys Nov 29, 2015

Contributor

I was not able to find any information of forward compatibility of the Oculus Runtime. Since this sounds rather unlikely, I will changed this to be 0.8.0.0-beta.

@Squareys

This comment has been minimized.

Contributor

Squareys commented Nov 26, 2015

  • Use sRGB framebuffer feature Renderer::Feature::FramebufferSRGB

Squareys added some commits Nov 29, 2015

ovr: M key to toggle mirroring on/off.
Also update readme.

Signed-off-by: Squareys <Squareys@googlemail.com>
ovr: Properly handle sRGB for mirroring sdk compositor results.
Since the target textures for the HMD have sRGB format now, they would be
blitted onto the mirror texture and then later from the mirror texture onto
the default framebuffer without proper conversion, resulting in different
images in the HMD compared to the mirror.
Therefore mirror texture and default framebuffer need to be in sRGB aswell.

Signed-off-by: Squareys <Squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:adapt-ovr-example branch from 3477de5 to ba6edf3 Nov 29, 2015

@Squareys

This comment has been minimized.

Contributor

Squareys commented Nov 29, 2015

@mosra Done with this aswell :)

@mosra mosra merged commit ba6edf3 into mosra:master Nov 30, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mosra

This comment has been minimized.

Owner

mosra commented Nov 30, 2015

Merged. Thank you!

@mosra mosra added this to the 2018.02 milestone Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment