New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the greek version of hello world! #35

Merged
merged 1 commit into from Jan 5, 2018

Conversation

2 participants
@costashatz
Contributor

costashatz commented Jan 5, 2018

There's a small typo in the greek version of hello world! ;)

@mosra mosra self-assigned this Jan 5, 2018

@mosra mosra merged commit 5ffc0b0 into mosra:master Jan 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mosra

This comment has been minimized.

Owner

mosra commented Jan 5, 2018

Hey, wow, thank you! :)

@mosra mosra added this to Done in Project management Jan 5, 2018

@costashatz

This comment has been minimized.

Contributor

costashatz commented Jan 5, 2018

Easy for me; I am Greek! 😛

@mosra

This comment has been minimized.

Owner

mosra commented Jan 5, 2018

I should have asked you for the correct version in the first place, back when I was creating this demo :D

What did it mean, anyway?

@costashatz

This comment has been minimized.

Contributor

costashatz commented Jan 5, 2018

The original one was saying (with a small grammar error): "Hello you, the world!"

The new one says exactly: "Hello world!"

Btw, you can update the png in this repo and the magnum website (showcase part).. I could do the first part if you don't have time; I think it's better if you do the second.. :D

@mosra

This comment has been minimized.

Owner

mosra commented Jan 5, 2018

Yeah, it's on my TODO list for today :) I'm doing various updates to documentation of all other examples, so this will get done along the way.

@mosra mosra added this to the 2018.02 milestone Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment