/magnum-examples

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added android port to viewer example #50

Closed
wants to merge 1 commit into
base: ports
from

Conversation

Reviewers
No reviews
Assignees

@mosra mosra

Labels
Projects
  
Done in Project management
Milestone
  2018.10
2 participants
@boonto @mosra
@boonto

boonto commented Sep 28, 2018 •
edited

  • adapted the viewer example to android, similar to the primitives example
  • added local.properties to the general .gitignore
  • replaced ColladaImporter comment info with OpenGexImporter comment info in the general CMakeLists
@boonto
Added android port to viewer example
Verified
This commit was signed with a verified signature.
@boonto boonto Patrick Werner
GPG key ID: C078A3328BEC8B94 Learn about signing commits
Loading status checks…
814c215

@mosra mosra added this to TODO in Project management via automation Oct 3, 2018

@mosra mosra added this to the 2018.0c milestone Oct 3, 2018

@mosra mosra self-assigned this Oct 3, 2018

@mosra

This comment has been minimized.

Sign in to view
Owner

mosra commented Oct 3, 2018

Hi, thank you a lot for this! 👍

I merged this in 61a4523 with a few very minor coding style updates. Also thanks for the heads up with the CMakeLists.txt comment, turns out a lot more was outdated there. It's hopefully all fixed now.

@mosra mosra closed this Oct 3, 2018

Project management automation moved this from TODO to Done Oct 3, 2018

@mosra mosra added the changelog mention added label Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment