ImGuiIntegration example #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mosra
reviewed
Nov 13, 2018
Squareys
force-pushed
the
imgui-example
branch
from
6fd8602 to
f6de140
Compare
Squareys
force-pushed
the
imgui-example
branch
from
f6de140 to
3f5aa2b
Compare
Squareys
force-pushed
the
imgui-example
branch
from
3f5aa2b to
1fe2820
Compare
|
@mosra Ready for review! :) |
mosra
reviewed
Dec 3, 2018
| The [ports branch](https://github.com/mosra/magnum-examples/tree/ports/src/imgui) | ||
| contains additional patches for @ref CORRADE_TARGET_EMSCRIPTEN "Emscripten" | ||
| support that aren't present in `master` in order to keep the example code as | ||
| simple as possible. |
There was a problem hiding this comment.
Sounds like a thing I should do post-merge, haha :)
Squareys
force-pushed
the
imgui-example
branch
from
69d874f to
ada2127
Compare
mosra
reviewed
Dec 5, 2018
Squareys
force-pushed
the
imgui-example
branch
from
ada2127 to
309e84c
Compare
Squareys
force-pushed
the
imgui-example
branch
3 times, most recently
from
779b454 to
f498e76
Compare
|
Updated the find modules and rebased onto master :) |
mosra
reviewed
Dec 16, 2018
Squareys
force-pushed
the
imgui-example
branch
4 times, most recently
from
dd94ea3 to
49dcc4d
Compare
|
Alright, now it should be done :D |
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
imgui-example
branch
from
49dcc4d to
decbab1
Compare
mosra
reviewed
Dec 16, 2018
| # Vladimír Vondruš <mosra@centrum.cz> | ||
| # 2018 — ShaddyAQN <ShaddyAQN@gmail.com> | ||
| # 2018 — Jonathan Hale <squareys@googlemail.com> | ||
| # 2018 — Thomas Skrivan <skrivantomas@seznam.cz> |
There was a problem hiding this comment.
2018 — Tomáš Skřivan <skrivantomas@seznam.cz>
... 😆
|
Merged in 37dab5b, thank you (and everyone else) for the great work! 🎉 Since this was impossible to test for you without the integration PR being merged, I amended the commit with up-to-date FindImGui and FindMagnumIntegration as well as other minor fixes in the CI scripts. The web demo is now ready as well: https://magnum.graphics/showcase/imgui/ |
|
Awesome! 🎉 And thank you so much for all the cleanup and improvements afterwards! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everybody!
This is the WIP PR for integrating the example from magnum-imgui into the main magnum repositories.
Cheers,
Jonathan
TODOs