Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webvr: Use EmscriptenApplication #60

Closed
wants to merge 3 commits into from

Conversation

Squareys
Copy link
Contributor

@Squareys Squareys commented May 5, 2019

Hey @mosra !

As part of mosra/magnum#300, here is the update for the webvr example.

Cheers, Jonathan.

@Squareys Squareys force-pushed the webvr-emscripten-application branch from bb5b7c9 to 8157676 Compare May 5, 2019 18:18
@Squareys Squareys mentioned this pull request May 5, 2019
24 tasks
Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except that one thing :)

src/webvr/webvr.html Outdated Show resolved Hide resolved
@mosra mosra added this to the 2019.0b milestone May 17, 2019
@mosra mosra self-assigned this May 17, 2019
Signed-off-by: Squareys <squareys@googlemail.com>
@Squareys Squareys force-pushed the webvr-emscripten-application branch from 7c92289 to cedcd8d Compare May 22, 2019 10:30
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
@Squareys Squareys force-pushed the webvr-emscripten-application branch from cedcd8d to 4fff16d Compare May 23, 2019 08:07
@Squareys
Copy link
Contributor Author

@mosra This is also ready for the next review :)

Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@mosra
Copy link
Owner

mosra commented Jun 6, 2019

Merged as b1ab220, 564a52f and 751797e. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants