webvr: Use EmscriptenApplication#60
Closed
Squareys wants to merge 3 commits intomosra:masterfrom
Closed
Conversation
Squareys
force-pushed
the
webvr-emscripten-application
branch
from
bb5b7c9 to
8157676
Compare
24 tasks
mosra
requested changes
May 17, 2019
Owner
mosra
left a comment
mosra
left a comment
There was a problem hiding this comment.
Looks good except that one thing :)
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
webvr-emscripten-application
branch
from
7c92289 to
cedcd8d
Compare
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
webvr-emscripten-application
branch
from
cedcd8d to
4fff16d
Compare
Contributor
Author
|
@mosra This is also ready for the next review :) |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @mosra !
As part of mosra/magnum#300, here is the update for the webvr example.
Cheers, Jonathan.