Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webvr: Use EmscriptenApplication #60

Closed
wants to merge 3 commits into from

Conversation

@Squareys
Copy link
Contributor

commented May 5, 2019

Hey @mosra !

As part of mosra/magnum#300, here is the update for the webvr example.

Cheers, Jonathan.

@Squareys Squareys force-pushed the Squareys:webvr-emscripten-application branch from bb5b7c9 to 8157676 May 5, 2019

@Squareys Squareys referenced this pull request May 5, 2019
24 of 24 tasks complete
@mosra
Copy link
Owner

left a comment

Looks good except that one thing :)

src/webvr/webvr.html Outdated Show resolved Hide resolved

@mosra mosra added this to the 2019.0b milestone May 17, 2019

@mosra mosra added this to TODO in Platforms via automation May 17, 2019

@mosra mosra self-assigned this May 17, 2019

webvr: Use EmscriptenApplication
Signed-off-by: Squareys <squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:webvr-emscripten-application branch from 7c92289 to cedcd8d May 22, 2019

Squareys added some commits May 5, 2019

modules: Update FindMagnum.cmake
Signed-off-by: Squareys <squareys@googlemail.com>
imgui: Accept scroll event when handled by imgui
Signed-off-by: Squareys <squareys@googlemail.com>

@Squareys Squareys force-pushed the Squareys:webvr-emscripten-application branch from cedcd8d to 4fff16d May 23, 2019

@Squareys

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@mosra This is also ready for the next review :)

@mosra

mosra approved these changes May 25, 2019

Copy link
Owner

left a comment

Looks good now!

@mosra

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2019

Merged as b1ab220, 564a52f and 751797e. Thanks a lot!

@mosra mosra closed this Jun 6, 2019

Platforms automation moved this from TODO to Done Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.