Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluid simulation example #69

Closed
wants to merge 2 commits into from
Closed

Conversation

@ttnghia
Copy link
Contributor

ttnghia commented Nov 2, 2019

Finally, fluid simulation example for magnum 馃槏
Please make a WebGL example of this. I don't know how to do it now :)
Let me know if there's anything needs to be changed.

image

@ttnghia ttnghia force-pushed the ttnghia:fluid-simulation branch from 57b3ed5 to b0633d2 Nov 2, 2019
@mosra mosra added this to the 2019.1c milestone Nov 2, 2019
@mosra mosra added this to TODO in Project management via automation Nov 2, 2019
@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Nov 2, 2019

Yay, Xmas come early this year! I need to try this out immediately :)

@alanjfs

This comment has been minimized.

Copy link

alanjfs commented Nov 2, 2019

The ThreadPool stuff is super interesting. :O Thanks for sharing this!

@alanjfs

This comment has been minimized.

Copy link

alanjfs commented Nov 2, 2019

Adding a gif, for easy sharing. :)

@ttnghia ttnghia force-pushed the ttnghia:fluid-simulation branch from b0633d2 to a2b5e8e Nov 2, 2019
@ttnghia

This comment has been minimized.

Copy link
Contributor Author

ttnghia commented Nov 2, 2019

I pushed new changes:

  • Add back tbb code.
  • Limit 60FPS rendering but maximize computation: run a number of simulation steps (which is dynamically computed) per frame.
@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Nov 4, 2019

Thank you, this is great 馃憤

Sorry for the lack of action on my side, got a priority thing to work on right now. I'll try to get this merged later this week.

鈥kes room for the upcomming fluidsimulation2d example.
@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Nov 8, 2019

Merged as 4fb94bd and ba5000c -- you did some great work, thanks a lot 馃憤 I didn't look into the WebGL port yet, hopefully soon :)

Docs for the example are at https://doc.magnum.graphics/magnum/examples-fluidsimulation3d.html -- I was not sure what exactly to put there, so if you have some further information, let me know.

@mosra mosra closed this Nov 8, 2019
Project management automation moved this from TODO to Done Nov 8, 2019
@ttnghia ttnghia deleted the ttnghia:fluid-simulation branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can鈥檛 perform that action at this time.