Skip to content

Add fluid simulation example#69

Closed
ttnghia wants to merge 2 commits into
mosra:masterfrom
ttnghia:fluid-simulation
Closed

Add fluid simulation example#69
ttnghia wants to merge 2 commits into
mosra:masterfrom
ttnghia:fluid-simulation

Conversation

@ttnghia

@ttnghia ttnghia commented Nov 2, 2019

Copy link
Copy Markdown
Contributor

Finally, fluid simulation example for magnum 😍
Please make a WebGL example of this. I don't know how to do it now :)
Let me know if there's anything needs to be changed.

image

@mosra mosra added this to the 2019.1c milestone Nov 2, 2019
@mosra

mosra commented Nov 2, 2019

Copy link
Copy Markdown
Owner

Yay, Xmas come early this year! I need to try this out immediately :)

@alanjfs

alanjfs commented Nov 2, 2019

Copy link
Copy Markdown
Contributor

The ThreadPool stuff is super interesting. :O Thanks for sharing this!

@alanjfs

alanjfs commented Nov 2, 2019

Copy link
Copy Markdown
Contributor

Adding a gif, for easy sharing. :)

@ttnghia

ttnghia commented Nov 2, 2019

Copy link
Copy Markdown
Contributor Author

I pushed new changes:

  • Add back tbb code.
  • Limit 60FPS rendering but maximize computation: run a number of simulation steps (which is dynamically computed) per frame.

@mosra

mosra commented Nov 4, 2019

Copy link
Copy Markdown
Owner

Thank you, this is great 👍

Sorry for the lack of action on my side, got a priority thing to work on right now. I'll try to get this merged later this week.

…akes room for the upcomming fluidsimulation2d example.
@mosra

mosra commented Nov 8, 2019

Copy link
Copy Markdown
Owner

Merged as 4fb94bd and ba5000c -- you did some great work, thanks a lot 👍 I didn't look into the WebGL port yet, hopefully soon :)

Docs for the example are at https://doc.magnum.graphics/magnum/examples-fluidsimulation3d.html -- I was not sure what exactly to put there, so if you have some further information, let me know.

@mosra mosra closed this Nov 8, 2019
@ttnghia ttnghia deleted the fluid-simulation branch November 10, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants