FluidSimulation3D example: fix bug, and change header guards - #70
Closed
ttnghia wants to merge 5 commits into
Closed
FluidSimulation3D example: fix bug, and change header guards#70ttnghia wants to merge 5 commits into
ttnghia wants to merge 5 commits into
Conversation
… same file names, header guard need to add example name.
mosra
approved these changes
Nov 10, 2019
mosra
left a comment
Owner
There was a problem hiding this comment.
Thank you! Much appreciated. I'll update the repo link in the docs (for the record, all that is in doc/fluidsimulation3d.dox in case you'd want to add things there).
Owner
|
Merged as 579a14c...db48e1d (without the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mosra,
I did some changes for the FluidSimulation example:
Also, the link in the example page (https://doc.magnum.graphics/magnum/examples-fluidsimulation3d.html):
is wrong.