Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluidSimulation3D example: fix bug, and change header guards #70

Closed
wants to merge 5 commits into from

Conversation

@ttnghia
Copy link
Contributor

ttnghia commented Nov 10, 2019

Hi @mosra,

I did some changes for the FluidSimulation example:

  • Fixed a bug: the particle color cannot be changed.
  • Fixed a bug: the light direction cannot be changed.
  • I changed header guards of the *.h files, adding example name. This is necessary if we have different examples having files with the same file names.
  • Fixed some warnings.
  • Improve menu.

Also, the link in the example page (https://doc.magnum.graphics/magnum/examples-fluidsimulation3d.html):

Full source code is linked below and also available in the magnum-examples GitHub repository.

is wrong.

ttnghia added 3 commits Nov 10, 2019
… same file names, header guard need to add example name.
@ttnghia ttnghia changed the title Fix color, and change header guards FluidSimulation3D example: fix bug, and change header guards Nov 10, 2019
ttnghia added 2 commits Nov 10, 2019
@mosra mosra added this to the 2019.1c milestone Nov 10, 2019
@mosra mosra added this to TODO in Project management via automation Nov 10, 2019
@mosra
mosra approved these changes Nov 10, 2019
Copy link
Owner

mosra left a comment

Thank you! Much appreciated. I'll update the repo link in the docs (for the record, all that is in doc/fluidsimulation3d.dox in case you'd want to add things there).

@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Nov 12, 2019

Merged as 579a14c...db48e1d (without the #include changes), thanks!

@mosra mosra closed this Nov 12, 2019
Project management automation moved this from TODO to Done Nov 12, 2019
@ttnghia ttnghia deleted the ttnghia:fluidsimulation3d branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.