Skip to content

FluidSimulation3D example: fix bug, and change header guards - #70

Closed
ttnghia wants to merge 5 commits into
mosra:masterfrom
ttnghia:fluidsimulation3d
Closed

FluidSimulation3D example: fix bug, and change header guards#70
ttnghia wants to merge 5 commits into
mosra:masterfrom
ttnghia:fluidsimulation3d

Conversation

@ttnghia

@ttnghia ttnghia commented Nov 10, 2019

Copy link
Copy Markdown
Contributor

Hi @mosra,

I did some changes for the FluidSimulation example:

  • Fixed a bug: the particle color cannot be changed.
  • Fixed a bug: the light direction cannot be changed.
  • I changed header guards of the *.h files, adding example name. This is necessary if we have different examples having files with the same file names.
  • Fixed some warnings.
  • Improve menu.

Also, the link in the example page (https://doc.magnum.graphics/magnum/examples-fluidsimulation3d.html):

Full source code is linked below and also available in the magnum-examples GitHub repository.

is wrong.

@ttnghia ttnghia changed the title Fix color, and change header guards FluidSimulation3D example: fix bug, and change header guards Nov 10, 2019
@mosra mosra added this to the 2019.1c milestone Nov 10, 2019

@mosra mosra left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Much appreciated. I'll update the repo link in the docs (for the record, all that is in doc/fluidsimulation3d.dox in case you'd want to add things there).

Comment thread src/fluidsimulation3d/DrawableObjects/FlatShadeObject.h
Comment thread src/fluidsimulation3d/SPH/DomainBox.cpp
@mosra

mosra commented Nov 12, 2019

Copy link
Copy Markdown
Owner

Merged as 579a14c...db48e1d (without the #include changes), thanks!

@mosra mosra closed this Nov 12, 2019
@ttnghia
ttnghia deleted the fluidsimulation3d branch November 12, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants