Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FluidSimulation3D example: fix bug, and change header guards #70

Closed
wants to merge 5 commits into from
Closed

FluidSimulation3D example: fix bug, and change header guards #70

wants to merge 5 commits into from

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Nov 10, 2019 •
edited

Hi @mosra,

I did some changes for the FluidSimulation example:

  • Fixed a bug: the particle color cannot be changed.
  • Fixed a bug: the light direction cannot be changed.
  • I changed header guards of the *.h files, adding example name. This is necessary if we have different examples having files with the same file names.
  • Fixed some warnings.
  • Improve menu.

Also, the link in the example page (https://doc.magnum.graphics/magnum/examples-fluidsimulation3d.html):

Full source code is linked below and also available in the magnum-examples GitHub repository.

is wrong.

@ttnghia ttnghia changed the title Fix color, and change header guards FluidSimulation3D example: fix bug, and change header guards Nov 10, 2019
@mosra mosra added this to the 2019.1c milestone Nov 10, 2019
@mosra mosra added this to TODO in Project management via automation Nov 10, 2019
mosra
mosra approved these changes Nov 10, 2019
View reviewed changes
Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Much appreciated. I'll update the repo link in the docs (for the record, all that is in doc/fluidsimulation3d.dox in case you'd want to add things there).

src/fluidsimulation3d/DrawableObjects/FlatShadeObject.h Show resolved Hide resolved
src/fluidsimulation3d/SPH/DomainBox.cpp Show resolved Hide resolved
@mosra
Copy link
Owner

mosra commented Nov 12, 2019

Merged as 579a14c...db48e1d (without the #include changes), thanks!

@mosra mosra closed this Nov 12, 2019
Project management automation moved this from TODO to Done Nov 12, 2019
@ttnghia ttnghia deleted the fluidsimulation3d branch November 12, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosra mosra mosra approved these changes

Assignees
No one assigned
Labels
changelog mention added
Projects
Project management
  
Done
Milestone
2020.06
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttnghia @mosra